fix: linting issues

Author: jackhodgkiss

doc/source/configuration/ci-cd.rst

@@ -220,7 +220,7 @@ Runner Deployment
    In this example we have two runners, one for production and one for staging and will both be deployed on the same host.
    This might not be possible for all deployments as multiple environments may require different runners as no single runner can serve all environments.
    Note a GitLab runner can run multiple jobs concurrently so deploying a single runner per environment is recommended.
-   
+
 .. code-block:: yaml
 
     ---
@@ -357,7 +357,7 @@ GitLab Pipelines
 1. Edit :code:`${KAYOBE_CONFIG_PATH}/inventory/group_vars/gitlab-writer/writer.yml` in the base configuration making the appropriate changes to your deployments specific needs. See documentation for `stackhpc.kayobe_workflows.gitlab <https://github.com/stackhpc/ansible-collection-kayobe-workflows/tree/main/roles/gitlab>`__.
 Following the instructions in the documentation will allow you to customise the workflows to fit within your deployment.
 For example disabling jobs that might not be relevant such as physical network configuration or overcloud host provision in clouds where this is absent.
-Also consider the impact runbooks might have as the runbooks are designed with a particular cloud in mind and may not be suitable for all deployments such as hyperconverged deployments with Ceph on hypervisors. 
+Also consider the impact runbooks might have as the runbooks are designed with a particular cloud in mind and may not be suitable for all deployments such as hyperconverged deployments with Ceph on hypervisors.
 
 2. Run :code:`kayobe playbook run ${KAYOBE_CONFIG_PATH}/ansible/write-gitlab-pipelines.yml`
 

etc/kayobe/ansible/deploy-openbao-kayobe-automation.yml

@@ -5,28 +5,29 @@
   hosts: github-runners,gitlab-runners
   tasks:
     - name: Set a fact about the virtualenv on the remote system
-      set_fact:
+      ansible.builtin.set_fact:
         virtualenv: "{{ ansible_python_interpreter | dirname | dirname }}"
       when:
         - ansible_python_interpreter is defined
         - not ansible_python_interpreter.startswith('/bin/')
         - not ansible_python_interpreter.startswith('/usr/bin/')
 
     - name: Ensure Python hvac module is installed
-      pip:
+      ansible.builtin.pip:
         name: hvac
         state: latest
         extra_args: "{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}"
         virtualenv: "{{ virtualenv is defined | ternary(virtualenv, omit) }}"
       become: "{{ virtualenv is not defined }}"
 
     - name: Ensure /opt/kayobe/vault exists
-      file:
+      ansible.builtin.file:
         path: /opt/kayobe/vault
         state: directory
       become: true
 
-    - import_role:
+    - name: Import OpenBao role
+      ansible.builtin.import_role:
         name: stackhpc.hashicorp.openbao
       vars:
         openbao_config_dir: "/opt/kayobe/vault"
@@ -36,12 +37,13 @@
         openbao_write_keys_file_path: "{{ kayobe_env_config_path }}/vault/kayobe-automation-keys.json"
 
     - name: Include OpenBao keys
-      include_vars:
+      ansible.builtin.include_vars:
         file: "{{ kayobe_env_config_path }}/vault/kayobe-automation-keys.json"
         name: openbao_keys
       tags: always
 
-    - import_role:
+    - name: Import Vault unseal role
+      ansible.builtin.import_role:
         name: stackhpc.hashicorp.vault_unseal
       vars:
         vault_api_addr: "{{ openbao_api_addr }}"
@@ -52,7 +54,7 @@
         https_proxy: ''
 
     - name: Create secret store
-      hashivault_secret_engine:
+      ansible.legacy.hashivault_secret_engine:
         name: kayobe-automation
         backend: kv
         url: "{{ openbao_api_addr }}"