simplified ref variables

Author: wtripp180901

.github/workflows/stackhpc-all-in-one.yml

@@ -63,16 +63,12 @@ on:
         description: Git version of https://github.com/stackhpc/stackhpc-cloud-tests to use for testing
         type: string
         default: main
-      called_from_external:
-        description: Set if using the workflow from an external repository
-        type: boolean
-        default: false
       repository:
-        description: SKC repository to checkout (convenience for CI)
+        description: SKC repository to checkout (convenience for external CI)
         type: string
         default: ${{ github.repository }}
-      external_ref_override:
-        description: Git ref to checkout, only used if called_from_external is true
+      github_ref:
+        description: Git ref to checkout (convenience for external CI)
         type: string
         default: ${{ github.ref }}
     secrets:
@@ -111,7 +107,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: ${{ inputs.repository }}
-          ref: ${{ inputs.upgrade && env.PREVIOUS_BRANCH || inputs.called_from_external && inputs.external_ref_override || github.ref }}
+          ref: ${{ inputs.upgrade && env.PREVIOUS_BRANCH || inputs.github_ref }}
           submodules: true
 
       - name: Output Kayobe image
@@ -385,6 +381,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: ${{ inputs.repository }}
+          ref: ${{ inputs.github_ref }}
           submodules: true
           clean: false
         if: inputs.upgrade