feat: add ironic environment mixins
#1729
Draft
+248
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhodgkiss
force-pushed
the
ironic-mixins
branch
from
ea94fab to
ba4853e
Compare
|
I'm a big fan of this approach. What do you need to get this out of draft? |
I think there a some further additions that could be included here. Horizon fixes (scopes and configuration drive default) Some documentation. I think something for the SKC docs but also something in environment such as small README.md to summerise what the stack does/doesn't do and what you need to do if include it. |
jackhodgkiss
force-pushed
the
ironic-mixins
branch
from
ba4853e to
44d7661
Compare
jackhodgkiss
force-pushed
the
ironic-mixins
branch
from
44d7661 to
d8b14e4
Compare
Add support for environment mixins that capture the configuration behind
`ironic` for both `redfish` and `ipmi`. It is expected the users
environments will depend on `stack-ironic-{redfish,ipmi}` and not
`stack-ironic`.
[no-ci]
jackhodgkiss
force-pushed
the
ironic-mixins
branch
from
d8b14e4 to
75a4a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for environment mixins that capture the configuration behind
ironicfor bothredfish,idracandipmi. It is expected the users environments will depend onstack-ironicand will simply add the nodes to the relevant groups..