-
Notifications
You must be signed in to change notification settings - Fork 23
Merge Openbao and Hashicorp Vault playbooks #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cherry-pick stackhpc/2024.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're planning on making the vault* and openbao* playbooks generic, and use a separate variable to choose between them
See discussion here for details: stackhpc/terraform-kayobe-multinode#93 (comment)
I'm putting this PR back to draft while we work on a new solution and Seunghun is away |
ca400f1
to
93c5748
Compare
35eb2d7
to
fe2c6c2
Compare
fe2c6c2
to
f47a2ac
Compare
Cherry-pick failed with |
The revert at stackhpc/terraform-kayobe-multinode#92 made Epoxy and Caracal ci-multinode to fail because SKC assumes that OpenBao is used as CA but multinode.sh at terraform-kayobe-multinode assumes vault.
This merge allows users to choose which secret store to use as CA.
Related PR: stackhpc/terraform-kayobe-multinode#94