-
Notifications
You must be signed in to change notification settings - Fork 23
Move Ansible playbooks into separate directories #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
d6bc9ed
to
c396e39
Compare
ffdb951
to
42fa998
Compare
Makes sense. Would be good to get them into the script before this gets merged though |
What do you think of dropping prefix of playbooks when the prefix and the category name is the same? Like secret-store, pulp, ceph. |
Discussed in-person |
c097a02
to
f519be5
Compare
f519be5
to
c336698
Compare
100 playbooks in the same directory are hard for human brains to parse. This change divides them up into sub-directories based on the content of the playbook. Below is a list of all the new categories. Pulp ==== pulp-container-publish.yml pulp-container-sync.yml pulp-host-image-download.yml pulp-repo-promote-production.yml pulp-amphora-image-download.yml pulp-repo-publish.yml pulp-artifact-promote.yml pulp-repo-sync.yml pulp-artifact-upload.yml pulp-sync-publish-promote.yml pulp-auth-proxy.yml Ceph ==== cephadm-keys.yml cephadm-pools.yml cephadm-commands-post.yml cephadm.yml cephadm-commands-pre.yml ceph-enter-maintenance.yml cephadm-crush-rules.yml ceph-exit-maintenance.yml cephadm-deploy.yml cephadm-ec-profiles.yml cephadm-gather-keys.yml Secret Store ==== secret-store-deploy-overcloud.yml secret-store-deploy-seed.yml secret-store-generate-backend-tls.yml secret-store-generate-internal-tls.yml secret-store-generate-test-external-tls.yml secret-store-unseal-overcloud.yml secret-store-unseal-seed.yml secret-store-deploy-barbican.yml Fixes ===== ovn-fix-chassis-priorities.yml run-container-hotfix.yml fix-grub-rl9.yml fix-hostname.yml fix-houston.yml fix-networking.yml hotfix-containers.yml rabbitmq-reset.yml purge-command-not-found.yml Deployment ========== deploy-github-runner.yml deploy-gitlab-runner.yml deploy-openbao-kayobe-automation.yml deploy-os-capacity-exporter.yml deploy-radosgw-usage-exporter.yml get-nvme-drives.yml smartmon-tools.yml wazuh-agent.yml wazuh-manager.yml wazuh-secrets.yml write-github-workflows.yml write-gitlab-pipelines.yml Maintenance =========== nova-compute-disable.yml nova-compute-drain.yml nova-compute-enable.yml reboot.yml rekey-hosts.yml reset-bls-entries.yml stop-openstack-services.yml pci-passthrough.yml ubuntu-upgrade.yml cis.yml octavia-amphora-image-build.yml octavia-amphora-image-register.yml Tools ===== advise-run.yml build-ofed-rocky.yml check-kayobe-version.yml check-kolla-ansible-version.yml check-kolla-images-py.yml check-tags.yml configure-aio-resources.yml configure-vxlan.yml diagnostics.yml docker-registry-login.yml firewalld-watchdog.yml get-cloud-facts.yml growroot.yml install-doca.yml install-pre-commit-hooks.yml openstack-host-image-upload.yml prometheus-network-names.yml prometheus.yml.j2 push-ofed.yml rsyslog.yml stackhpc-cloud-tests.yml Playbook paths were edited with a set of commands like this: grep -rFIl '/cephadm-keys.yml' tools/ doc/source/ .ansible-lint-ignore etc/ .github/ .automation.conf/ terraform/ | xargs sed -i s:/cephadm-keys.yml:/ceph/cephadm-keys.yml:g Commands were generated for every playbook using some multiline edits in vscode Added scripts for fixing Ansible playbook paths To make the transition easier, this change includes a magic script which will fix symlink paths. Also added docs and fixed existing symlink paths
This change subdivides the playbooks under the
etc/kayobe/ansible/
directory into categories based on the content and purpose of the playbook.The new categories are:
The changes have been applied using various scripts, a few of which I have refined and added to this PR, namely:
tools/get-new-playbook-path.sh
- returns the new category of a given playbooktools/magic-symlink-fix.sh
- Fixes all the symlinks it can find, using the previous script