Fix overriding nova config files when gpu_group_map is unset #1879
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mnasiadka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces conditional rendering for GPU-related configuration sections within Nova's configuration files. By wrapping these sections in if statements that check for the presence of gpu_group_map entries, it prevents the generation of empty or problematic configuration when GPU mapping is not in use, thus improving the robustness of the deployment process.
Highlights
- Conditional Configuration: Implemented conditional logic in Nova configuration files (nova-api.conf, nova-compute.conf, nova-scheduler.conf) to ensure GPU-related sections are only included when gpu_group_map is defined and contains entries.
- Preventing Configuration Overrides: This change specifically addresses an issue where Nova configuration files could be incorrectly generated or overridden when the gpu_group_map variable was unset or empty, leading to potential operational problems.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where Nova configuration files were being overridden even when gpu_group_map was not set. The fix involves wrapping the relevant configuration sections in nova-api.conf, nova-compute.conf, and nova-scheduler.conf with a conditional check. This ensures that the PCI and scheduler configurations are only generated when gpu_group_map is defined and contains data. The changes are correct and achieve the intended goal. I've provided a suggestion to simplify the conditional check for better readability and conciseness, which is applied consistently across all three modified files.
mnasiadka
force-pushed
the
fix_gpu_configs
branch
from
434e64d to
caba84e
Compare
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
mnasiadka
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
Alex-Welsh
force-pushed
the
fix_gpu_configs
branch
from
2e30f58 to
6130e53
Compare
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
* Fix overriding nova config files when gpu_group_map is unset * Update etc/kayobe/kolla/config/nova/nova-api.conf Co-authored-by: Alex Welsh <[email protected]> --------- Co-authored-by: Alex Welsh <[email protected]>
* Fix overriding nova config files when gpu_group_map is unset * Update etc/kayobe/kolla/config/nova/nova-api.conf Co-authored-by: Alex Welsh <[email protected]> --------- Co-authored-by: Alex Welsh <[email protected]>
No description provided.