rocky/aarch64: switch to versioned Erlang 26/27 repos #432
Conversation
Aligns with Kolla change [1]. Remove unversioned RabbitMQ Erlang COPR entry. Add Erlang 26 and 27 aarch64 repos. [1] https://review.opendev.org/c/openstack/kolla/+/959323 Signed-off-by: Bartosz Bezak <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bbezak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the package repository configurations to ensure that RabbitMQ on RHEL 9 aarch64 systems correctly fetches specific versions of Erlang (26 and 27). This change is crucial for maintaining compatibility and leveraging newer Erlang features, aligning the project's dependencies with upstream best practices and other related projects.
Highlights
- Erlang Repository Update: Updated the Erlang package repositories for RabbitMQ on RHEL 9 aarch64 to use specific versioned repositories (Erlang 26 and 27) instead of a generic unversioned one.
- Alignment with Kolla: This change aligns the repository configuration with a recent update in the Kolla project.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the RabbitMQ Erlang repository definitions for aarch64 on Rocky Linux 9. It replaces a single unversioned repository with two new versioned repositories for Erlang 26 and 27. The changes are consistent with the existing file structure and conventions. The updates to URLs, paths, and names are all correct according to the change in Erlang versions. The change aligns with the description and appears to be a correct and clean update.
Aligns with Kolla change [1].
Remove unversioned RabbitMQ Erlang COPR entry.
Add Erlang 26 and 27 aarch64 repos.
[1] https://review.opendev.org/c/openstack/kolla/+/959323
SKC change will follow.