Fix diagnostics.yml playbook path for Epoxy

[seunghun1ee]

Currently Multinode CI is failing to fetch logs because it's using old path of diagnostics.yml playbook.
Fixing this by updating the playbook path

[gemini-code-assist]

Summary of Changes

Hello @seunghun1ee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical failure in the Multinode CI pipeline. By updating the reference to the diagnostics.yml playbook, the system can now correctly locate and execute the necessary diagnostic steps, ensuring that logs are fetched as expected and preventing further CI failures related to this path.

Highlights

• CI Fix: Corrected the path for the diagnostics.yml playbook within ansible/fetch-logs.yml to ansible/tools/diagnostics.yml. This resolves an issue where Multinode CI was failing to fetch logs due to an outdated playbook path.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where the multinode CI was failing to fetch logs due to an incorrect path for the diagnostics.yml playbook. The change correctly updates the path in ansible/fetch-logs.yml. I've added one suggestion to improve the maintainability of the shell script by using a variable for the playbook path, which avoids repetition and makes future changes easier.

[gemini-code-assist]

To improve maintainability and avoid repeating the playbook path, you could define it in a variable and reuse it. This makes future updates to the path easier as it only needs to be changed in one place.

          diagnostics_playbook="$KAYOBE_CONFIG_PATH/ansible/tools/diagnostics.yml"
          if [[ -f "$diagnostics_playbook" ]]; then
            kayobe playbook run "$diagnostics_playbook" -e diagnostics_path_local={{ diagnostics_path_control_host }}
          else
            echo "Missing diagnostics playbook - skipping"
          fi

[seunghun1ee]

Test running at
https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/19761624219

[Alex-Welsh]

Actually, this still needs to support Caracal for upgrade jobs right?

Currently if it fails during the Caracal deployment, it won't trigger diagnostics

Can you add a new condition that also checks the old path if the new path doesn't exist?

[seunghun1ee]

I thought we're doing something like stackhpc/stackhpc-openstack-gh-workflows#16