Skip to content

Fix diagnostics.yml playbook path for Epoxy #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix diagnostics.yml playbook path for Epoxy #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ansible/fetch-logs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
source ~/venvs/kayobe/bin/activate
source ~/src/kayobe-config/kayobe-env --environment ci-multinode
export KAYOBE_VAULT_PASSWORD=$(cat ~/vault.password)
if [[ -f $KAYOBE_CONFIG_PATH/ansible/diagnostics.yml ]]; then
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/diagnostics.yml -e diagnostics_path_local={{ diagnostics_path_control_host }}
if [[ -f $KAYOBE_CONFIG_PATH/ansible/tools/diagnostics.yml ]]; then
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/tools/diagnostics.yml -e diagnostics_path_local={{ diagnostics_path_control_host }}
else
echo "Missing diagnostics playbook - skipping"
fi
Comment on lines +32 to 36
Copy link

@gemini-code-assist gemini-code-assist bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid repeating the playbook path, you could define it in a variable and reuse it. This makes future updates to the path easier as it only needs to be changed in one place.

          diagnostics_playbook="$KAYOBE_CONFIG_PATH/ansible/tools/diagnostics.yml"
          if [[ -f "$diagnostics_playbook" ]]; then
            kayobe playbook run "$diagnostics_playbook" -e diagnostics_path_local={{ diagnostics_path_control_host }}
          else
            echo "Missing diagnostics playbook - skipping"
          fi

Expand Down