fix: fix memory alignment warnings

stackia · stackia · commit 7aed96d0f5a6 · 2025-12-13T02:18:21.000+08:00
diff --git a/src/fcc.c b/src/fcc.c
@@ -9,6 +9,7 @@
 #include "utils.h"
 #include "worker.h"
 #include <errno.h>
+#include <inttypes.h>
 #include <netinet/in.h>
 #include <stdio.h>
 #include <string.h>
@@ -236,7 +237,8 @@ int fcc_initialize_and_request(stream_context_t *ctx) {
     slen = sizeof(fcc->fcc_client);
     getsockname(fcc->fcc_sock, (struct sockaddr *)&fcc->fcc_client, &slen);
 
-    fcc->fcc_server = (struct sockaddr_in *)service->fcc_addr->ai_addr;
+    fcc->fcc_server =
+        (struct sockaddr_in *)(uintptr_t)service->fcc_addr->ai_addr;
 
     /* Register socket with epoll immediately after creation */
     struct epoll_event ev;
@@ -462,7 +464,7 @@ int fcc_handle_mcast_active(stream_context_t *ctx, buffer_ref_t *buf_ref) {
     fcc->pending_list_tail = NULL;
 
     logger(LOG_DEBUG,
-           "FCC: Flushed pending buffer chain, total_flushed_bytes=%lu",
+           "FCC: Flushed pending buffer chain, total_flushed_bytes=%" PRIu64,
            flushed_bytes);
   }
 
diff --git a/src/fcc_huawei.c b/src/fcc_huawei.c
@@ -17,7 +17,8 @@
  */
 uint8_t *build_fcc_request_pk_huawei(struct addrinfo *maddr, uint32_t local_ip,
                                      uint16_t fcc_client_nport) {
-  struct sockaddr_in *maddr_sin = (struct sockaddr_in *)maddr->ai_addr;
+  struct sockaddr_in *maddr_sin =
+      (struct sockaddr_in *)(uintptr_t)maddr->ai_addr;
 
   static uint8_t pk[FCC_PK_LEN_REQ_HUAWEI];
   memset(&pk, 0, sizeof(pk));
@@ -76,7 +77,8 @@ uint8_t *build_fcc_nat_pk_huawei(uint32_t session_id) {
  * Build Huawei FCC termination packet - FMT 9
  */
 uint8_t *build_fcc_term_pk_huawei(struct addrinfo *maddr, uint16_t seqn) {
-  struct sockaddr_in *maddr_sin = (struct sockaddr_in *)maddr->ai_addr;
+  struct sockaddr_in *maddr_sin =
+      (struct sockaddr_in *)(uintptr_t)maddr->ai_addr;
 
   static uint8_t pk[FCC_PK_LEN_TERM_HUAWEI];
   memset(&pk, 0, sizeof(pk));
diff --git a/src/fcc_telecom.c b/src/fcc_telecom.c
@@ -11,7 +11,8 @@
 
 uint8_t *build_fcc_request_pk_telecom(struct addrinfo *maddr,
                                       uint16_t fcc_client_nport) {
-  struct sockaddr_in *maddr_sin = (struct sockaddr_in *)maddr->ai_addr;
+  struct sockaddr_in *maddr_sin =
+      (struct sockaddr_in *)(uintptr_t)maddr->ai_addr;
 
   static uint8_t pk[FCC_PK_LEN_REQ_TELECOM];
   memset(&pk, 0, sizeof(pk));
@@ -40,7 +41,8 @@ uint8_t *build_fcc_request_pk_telecom(struct addrinfo *maddr,
 }
 
 uint8_t *build_fcc_term_pk_telecom(struct addrinfo *maddr, uint16_t seqn) {
-  struct sockaddr_in *maddr_sin = (struct sockaddr_in *)maddr->ai_addr;
+  struct sockaddr_in *maddr_sin =
+      (struct sockaddr_in *)(uintptr_t)maddr->ai_addr;
 
   static uint8_t pk[FCC_PK_LEN_TERM_TELECOM];
   memset(&pk, 0, sizeof(pk));
diff --git a/src/hashmap.c b/src/hashmap.c
@@ -80,7 +80,7 @@ void hashmap_set_load_factor(struct hashmap *map, double factor) {
 }
 
 static struct bucket *bucket_at0(void *buckets, size_t bucketsz, size_t i) {
-  return (struct bucket *)(((char *)buckets) + (bucketsz * i));
+  return (struct bucket *)((uintptr_t)buckets + (bucketsz * i));
 }
 
 static struct bucket *bucket_at(const struct hashmap *map, size_t index) {
@@ -571,145 +571,6 @@ static uint64_t SIP64(const uint8_t *in, const size_t inlen, uint64_t seed0,
   return out;
 }
 
-//-----------------------------------------------------------------------------
-// MurmurHash3 was written by Austin Appleby, and is placed in the public
-// domain. The author hereby disclaims copyright to this source code.
-//
-// Murmur3_86_128
-//-----------------------------------------------------------------------------
-static uint64_t MM86128(const void *key, const int len, uint32_t seed) {
-#define ROTL32(x, r) ((x << r) | (x >> (32 - r)))
-#define FMIX32(h)                                                              \
-  h ^= h >> 16;                                                                \
-  h *= 0x85ebca6b;                                                             \
-  h ^= h >> 13;                                                                \
-  h *= 0xc2b2ae35;                                                             \
-  h ^= h >> 16;
-  const uint8_t *data = (const uint8_t *)key;
-  const int nblocks = len / 16;
-  uint32_t h1 = seed;
-  uint32_t h2 = seed;
-  uint32_t h3 = seed;
-  uint32_t h4 = seed;
-  uint32_t c1 = 0x239b961b;
-  uint32_t c2 = 0xab0e9789;
-  uint32_t c3 = 0x38b34ae5;
-  uint32_t c4 = 0xa1e38b93;
-  const uint32_t *blocks = (const uint32_t *)(data + nblocks * 16);
-  for (int i = -nblocks; i; i++) {
-    uint32_t k1 = blocks[i * 4 + 0];
-    uint32_t k2 = blocks[i * 4 + 1];
-    uint32_t k3 = blocks[i * 4 + 2];
-    uint32_t k4 = blocks[i * 4 + 3];
-    k1 *= c1;
-    k1 = ROTL32(k1, 15);
-    k1 *= c2;
-    h1 ^= k1;
-    h1 = ROTL32(h1, 19);
-    h1 += h2;
-    h1 = h1 * 5 + 0x561ccd1b;
-    k2 *= c2;
-    k2 = ROTL32(k2, 16);
-    k2 *= c3;
-    h2 ^= k2;
-    h2 = ROTL32(h2, 17);
-    h2 += h3;
-    h2 = h2 * 5 + 0x0bcaa747;
-    k3 *= c3;
-    k3 = ROTL32(k3, 17);
-    k3 *= c4;
-    h3 ^= k3;
-    h3 = ROTL32(h3, 15);
-    h3 += h4;
-    h3 = h3 * 5 + 0x96cd1c35;
-    k4 *= c4;
-    k4 = ROTL32(k4, 18);
-    k4 *= c1;
-    h4 ^= k4;
-    h4 = ROTL32(h4, 13);
-    h4 += h1;
-    h4 = h4 * 5 + 0x32ac3b17;
-  }
-  const uint8_t *tail = (const uint8_t *)(data + nblocks * 16);
-  uint32_t k1 = 0;
-  uint32_t k2 = 0;
-  uint32_t k3 = 0;
-  uint32_t k4 = 0;
-  switch (len & 15) {
-  case 15:
-    k4 ^= tail[14] << 16; /* fall through */
-  case 14:
-    k4 ^= tail[13] << 8; /* fall through */
-  case 13:
-    k4 ^= tail[12] << 0;
-    k4 *= c4;
-    k4 = ROTL32(k4, 18);
-    k4 *= c1;
-    h4 ^= k4;
-    /* fall through */
-  case 12:
-    k3 ^= tail[11] << 24; /* fall through */
-  case 11:
-    k3 ^= tail[10] << 16; /* fall through */
-  case 10:
-    k3 ^= tail[9] << 8; /* fall through */
-  case 9:
-    k3 ^= tail[8] << 0;
-    k3 *= c3;
-    k3 = ROTL32(k3, 17);
-    k3 *= c4;
-    h3 ^= k3;
-    /* fall through */
-  case 8:
-    k2 ^= tail[7] << 24; /* fall through */
-  case 7:
-    k2 ^= tail[6] << 16; /* fall through */
-  case 6:
-    k2 ^= tail[5] << 8; /* fall through */
-  case 5:
-    k2 ^= tail[4] << 0;
-    k2 *= c2;
-    k2 = ROTL32(k2, 16);
-    k2 *= c3;
-    h2 ^= k2;
-    /* fall through */
-  case 4:
-    k1 ^= tail[3] << 24; /* fall through */
-  case 3:
-    k1 ^= tail[2] << 16; /* fall through */
-  case 2:
-    k1 ^= tail[1] << 8; /* fall through */
-  case 1:
-    k1 ^= tail[0] << 0;
-    k1 *= c1;
-    k1 = ROTL32(k1, 15);
-    k1 *= c2;
-    h1 ^= k1;
-    /* fall through */
-  };
-  h1 ^= len;
-  h2 ^= len;
-  h3 ^= len;
-  h4 ^= len;
-  h1 += h2;
-  h1 += h3;
-  h1 += h4;
-  h2 += h1;
-  h3 += h1;
-  h4 += h1;
-  FMIX32(h1);
-  FMIX32(h2);
-  FMIX32(h3);
-  FMIX32(h4);
-  h1 += h2;
-  h1 += h3;
-  h1 += h4;
-  h2 += h1;
-  h3 += h1;
-  h4 += h1;
-  return (((uint64_t)h2) << 32) | h1;
-}
-
 //-----------------------------------------------------------------------------
 // xxHash Library
 // Copyright (c) 2012-2021 Yann Collet
@@ -842,13 +703,6 @@ uint64_t hashmap_sip(const void *data, size_t len, uint64_t seed0,
   return SIP64((const uint8_t *)data, len, seed0, seed1);
 }
 
-// hashmap_murmur returns a hash value for `data` using Murmur3_86_128.
-uint64_t hashmap_murmur(const void *data, size_t len, uint64_t seed0,
-                        uint64_t seed1) {
-  (void)seed1;
-  return MM86128(data, len, seed0);
-}
-
 uint64_t hashmap_xxhash3(const void *data, size_t len, uint64_t seed0,
                          uint64_t seed1) {
   (void)seed1;
diff --git a/src/m3u.c b/src/m3u.c
@@ -259,9 +259,10 @@ char *get_server_address(void) {
 
     /* Only process IPv4 for now */
     if (ifa->ifa_addr->sa_family == AF_INET) {
-      struct sockaddr_in *addr = (struct sockaddr_in *)ifa->ifa_addr;
+      struct sockaddr_in addr;
+      memcpy(&addr, ifa->ifa_addr, sizeof(addr));
 
-      if (inet_ntop(AF_INET, &addr->sin_addr, addr_str, sizeof(addr_str)) ==
+      if (inet_ntop(AF_INET, &addr.sin_addr, addr_str, sizeof(addr_str)) ==
           NULL)
         continue;
 
diff --git a/src/multicast.c b/src/multicast.c
@@ -196,7 +196,8 @@ uint32_t get_local_ip_for_fcc(void) {
 
       if (ifa->ifa_addr->sa_family == AF_INET &&
           strcmp(ifa->ifa_name, ifname) == 0) {
-        struct sockaddr_in *addr = (struct sockaddr_in *)ifa->ifa_addr;
+        struct sockaddr_in *addr =
+            (struct sockaddr_in *)(uintptr_t)ifa->ifa_addr;
         local_ip = ntohl(addr->sin_addr.s_addr);
         logger(LOG_DEBUG, "FCC: Using local IP from interface %s: %u.%u.%u.%u",
                ifname, (local_ip >> 24) & 0xFF, (local_ip >> 16) & 0xFF,
@@ -213,7 +214,8 @@ uint32_t get_local_ip_for_fcc(void) {
         continue;
 
       if (ifa->ifa_addr->sa_family == AF_INET) {
-        struct sockaddr_in *addr = (struct sockaddr_in *)ifa->ifa_addr;
+        struct sockaddr_in *addr =
+            (struct sockaddr_in *)(uintptr_t)ifa->ifa_addr;
         uint32_t ip = ntohl(addr->sin_addr.s_addr);
 
         /* Skip loopback (127.0.0.0/8) */
@@ -259,7 +261,8 @@ static int prepare_mcast_group_req(service_t *service, struct group_req *gr,
   case AF_INET6:
     level = SOL_IPV6;
     gr->gr_interface =
-        ((const struct sockaddr_in6 *)(service->addr->ai_addr))->sin6_scope_id;
+        ((struct sockaddr_in6 *)(uintptr_t)service->addr->ai_addr)
+            ->sin6_scope_id;
     break;
   default:
     logger(LOG_ERROR, "Address family don't support mcast.");
@@ -393,7 +396,7 @@ int rejoin_mcast_group(service_t *service) {
     return -1;
   }
 
-  mcast_addr = (struct sockaddr_in *)service->addr->ai_addr;
+  mcast_addr = (struct sockaddr_in *)(uintptr_t)service->addr->ai_addr;
   group_addr = mcast_addr->sin_addr.s_addr;
 
   if (service->msrc != NULL && strcmp(service->msrc, "") != 0 &&
@@ -402,7 +405,7 @@ int rejoin_mcast_group(service_t *service) {
       logger(LOG_ERROR, "IGMP raw socket rejoin: source address must be IPv4");
       return -1;
     }
-    source_addr = (struct sockaddr_in *)service->msrc_addr->ai_addr;
+    source_addr = (struct sockaddr_in *)(uintptr_t)service->msrc_addr->ai_addr;
     is_ssm = 1;
     nsrcs = 1;
   }
@@ -449,7 +452,7 @@ int rejoin_mcast_group(service_t *service) {
     grec->grec_nsrcs = htons(nsrcs);
     grec->grec_mca = group_addr;
     uint32_t *src_list =
-        (uint32_t *)((uint8_t *)grec + sizeof(struct igmpv3_grec));
+        (uint32_t *)((uintptr_t)grec + sizeof(struct igmpv3_grec));
     src_list[0] = source_addr->sin_addr.s_addr;
     packet_len_v3 = sizeof(struct igmpv3_report) + sizeof(struct igmpv3_grec) +
                     sizeof(uint32_t);
diff --git a/src/rtsp.c b/src/rtsp.c
@@ -2399,8 +2399,9 @@ static void rtsp_send_udp_nat_probe(rtsp_session_t *session) {
       /* Send RTCP probe - update port in sockaddr */
       if (session->server_rtcp_port > 0 && session->rtcp_socket >= 0) {
         if (rp->ai_family == AF_INET) {
-          ((struct sockaddr_in *)rp->ai_addr)->sin_port =
-              htons(session->server_rtcp_port);
+          struct sockaddr_in *addr =
+              (struct sockaddr_in *)(uintptr_t)rp->ai_addr;
+          addr->sin_port = htons(session->server_rtcp_port);
         }
         sendto(session->rtcp_socket, rtcp_packet, sizeof(rtcp_packet), 0,
                rp->ai_addr, rp->ai_addrlen);
diff --git a/src/zerocopy.c b/src/zerocopy.c
@@ -503,7 +503,7 @@ int zerocopy_handle_completions(int fd, zerocopy_queue_t *queue) {
       if ((cmsg->cmsg_level == SOL_IP && cmsg->cmsg_type == IP_RECVERR) ||
           (cmsg->cmsg_level == SOL_IPV6 && cmsg->cmsg_type == IPV6_RECVERR)) {
         struct sock_extended_err *serr =
-            (struct sock_extended_err *)CMSG_DATA(cmsg);
+            (struct sock_extended_err *)(uintptr_t)CMSG_DATA(cmsg);
 
         if (serr->ee_origin == SO_EE_ORIGIN_ZEROCOPY) {
           uint32_t lo = serr->ee_info;
