Deprecating CaptureErrorPostData

Author: Matt Brooks

Src/StackifyLib.AspNetCore/WebRequestDetailMapper.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
+using System.Text;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.Extensions.DependencyInjection;
@@ -30,7 +32,7 @@ internal static void WebRequestDetail_SetWebRequestDetail(WebRequestDetail detai
 
         private static void Load(HttpContext context, WebRequestDetail detail)
         {
-            if (context == null || context.Request == null)
+            if (context?.Request == null)
             {
                 return;
             }
@@ -58,7 +60,7 @@ private static void Load(HttpContext context, WebRequestDetail detail)
 
             try
             {
-                if (request.QueryString != null)
+                if (request.QueryString.HasValue)
                 {
                     detail.QueryString = ToKeyValues(request.Query, null, null);
                 }
@@ -87,11 +89,6 @@ private static void Load(HttpContext context, WebRequestDetail detail)
                 {
                     detail.Cookies = ToKeyValues(request.Cookies, Config.ErrorCookiesGoodKeys, Config.ErrorCookiesBadKeys);
                 }
-
-                if (request.Form != null && Config.CaptureErrorPostdata)
-                {
-                    detail.PostData = ToKeyValues(request.Form, null, null);
-                }
             }
             catch (Exception)
             {

Src/StackifyLib/Config.cs

@@ -31,8 +31,6 @@ public static void LoadSettings()
         {
             try
             {
-                CaptureErrorPostdata = Get("Stackify.CaptureErrorPostdata", bool.FalseString).Equals(bool.TrueString, StringComparison.CurrentCultureIgnoreCase);
-
                 CaptureServerVariables = Get("Stackify.CaptureServerVariables", bool.FalseString).Equals(bool.TrueString, StringComparison.CurrentCultureIgnoreCase);
 
                 CaptureSessionVariables = Get("Stackify.CaptureSessionVariables", bool.FalseString).Equals(bool.TrueString, StringComparison.CurrentCultureIgnoreCase);

Src/StackifyLib/Models/WebRequestDetail.cs

@@ -209,24 +209,6 @@ public void Load(HttpContextBase context)
                 {
                     SessionData = ToKeyValues(context.Session, Config.ErrorSessionGoodKeys, null);
                 }
-
-                if (Config.CaptureErrorPostdata)
-                {
-                    var contentType = context.Request.Headers["Content-Type"];
-
-                    if (contentType != "text/html" && contentType != "application/x-www-form-urlencoded" &&
-                        context.Request.RequestType != "GET")
-                    {
-                        int length = 4096;
-                        string postBody = new StreamReader(context.Request.InputStream).ReadToEnd();
-                        if (postBody.Length < length)
-                        {
-                            length = postBody.Length;
-                        }
-
-                        PostDataRaw = postBody.Substring(0, length);
-                    }
-                }
             }
             catch
             {