Skip to content

Commit 01ebe32

Browse files
committed
fix(loadbalancer): show correct number of listeners & targets in list cmd
1 parent a18c6bd commit 01ebe32

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

internal/cmd/load-balancer/list/list.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,21 @@ func outputResult(p *print.Printer, outputFormat string, loadBalancers []loadbal
154154
table.SetHeader("NAME", "STATE", "IP ADDRESS", "LISTENERS", "TARGET POOLS")
155155
for i := range loadBalancers {
156156
l := loadBalancers[i]
157-
externalAdress := utils.PtrStringDefault(l.ExternalAddress, "-")
157+
var numListeners, numTargetPools int
158+
if l.Listeners != nil {
159+
numListeners = len(*l.Listeners)
160+
}
161+
if l.TargetPools != nil {
162+
numTargetPools = len(*l.TargetPools)
163+
}
164+
165+
externalAddress := utils.PtrStringDefault(l.ExternalAddress, "-")
158166
table.AddRow(
159167
utils.PtrString(l.Name),
160168
utils.PtrString(l.Status),
161-
externalAdress,
162-
len(utils.PtrString(l.Listeners)),
163-
len(utils.PtrString(l.TargetPools)),
169+
externalAddress,
170+
numListeners,
171+
numTargetPools,
164172
)
165173
}
166174
err := table.Display(p)

internal/cmd/load-balancer/list/list_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,13 @@ func TestOutputResult(t *testing.T) {
202202
args: args{},
203203
wantErr: false,
204204
},
205+
{
206+
name: "empty loadbalancers slice",
207+
args: args{
208+
loadBalancers: []loadbalancer.LoadBalancer{},
209+
},
210+
wantErr: false,
211+
},
205212
{
206213
name: "empty loadbalancer in loadbalancers slice",
207214
args: args{

0 commit comments

Comments
 (0)