fix labelselector, config volumeID

Author: Benjosh95

internal/cmd/volume/snapshot/create/create.go

@@ -118,7 +118,7 @@ func NewCmd(params *params.CmdParams) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	cmd.Flags().Var(flags.UUIDFlag(), volumeIdFlag, "Volume ID")
+	cmd.Flags().Var(flags.UUIDFlag(), volumeIdFlag, "ID of the volume from which a snapshot should be created")
 	cmd.Flags().String(nameFlag, "", "Name of the snapshot")
 	cmd.Flags().StringToString(labelsFlag, nil, "Key-value string pairs as labels")
 

internal/cmd/volume/snapshot/list/list.go

@@ -139,7 +139,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
 func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiListSnapshotsRequest {
 	req := apiClient.ListSnapshots(ctx, model.ProjectId)
 	if model.LabelSelector != nil {
-		req.LabelSelector(*model.LabelSelector)
+		req = req.LabelSelector(*model.LabelSelector)
 	}
 	return req
 }

internal/cmd/volume/snapshot/list/list_test.go

@@ -52,6 +52,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 
 func fixtureRequest(mods ...func(request *iaas.ApiListSnapshotsRequest)) iaas.ApiListSnapshotsRequest {
 	request := testClient.ListSnapshots(testCtx, testProjectId)
+	request = request.LabelSelector("key1=value1")
 	for _, mod := range mods {
 		mod(&request)
 	}
@@ -174,6 +175,15 @@ func TestBuildRequest(t *testing.T) {
 			model:           fixtureInputModel(),
 			expectedRequest: fixtureRequest(),
 		},
+		{
+			description: "without label selector",
+			model: fixtureInputModel(func(model *inputModel) {
+				model.LabelSelector = nil
+			}),
+			expectedRequest: fixtureRequest(func(request *iaas.ApiListSnapshotsRequest) {
+				*request = testClient.ListSnapshots(testCtx, testProjectId)
+			}),
+		},
 	}
 
 	for _, tt := range tests {