Skip to content

Commit 2696abb

Browse files
committed
feat: Improvement after review
1 parent 9c26cb6 commit 2696abb

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

internal/cmd/beta/server/describe/describe.go

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -210,24 +210,22 @@ func outputResult(p *print.Printer, model *inputModel, server *iaas.Server) erro
210210
}
211211

212212
if server.Nics != nil && len(*server.Nics) > 0 {
213-
for i, nic := range *server.Nics {
214-
nicsTable := tables.NewTable()
215-
nicsTable.SetTitle(fmt.Sprintf("Attached Network Interface #%d", i))
213+
nicsTable := tables.NewTable()
214+
nicsTable.SetTitle("Attached Network Interfaces")
215+
nicsTable.SetHeader("ID", "NETWORK ID", "NETWORK NAME", "PUBLIC IP")
216216

217-
nicsTable.AddRow("ID", *nic.NicId)
218-
nicsTable.AddSeparator()
219-
nicsTable.AddRow("NETWORK ID", *nic.NetworkId)
220-
nicsTable.AddSeparator()
221-
nicsTable.AddRow("NETWORK NAME", *nic.NetworkName)
222-
nicsTable.AddSeparator()
217+
for _, nic := range *server.Nics {
218+
publicIp := ""
223219
if nic.PublicIp != nil {
224-
nicsTable.AddRow("PUBLIC IP", *nic.PublicIp)
220+
publicIp = *nic.PublicIp
225221
}
222+
nicsTable.AddRow(*nic.NicId, *nic.NetworkId, *nic.NetworkName, publicIp)
223+
nicsTable.AddSeparator()
224+
}
226225

227-
err := nicsTable.Display(p)
228-
if err != nil {
229-
return fmt.Errorf("render table: %w", err)
230-
}
226+
err := nicsTable.Display(p)
227+
if err != nil {
228+
return fmt.Errorf("render table: %w", err)
231229
}
232230
}
233231

0 commit comments

Comments
 (0)