Skip to content

Commit 2989128

Browse files
dependabot[bot]rubenhoenle
authored andcommitted
fix(postgresflex): remove storage class flag from instance update cmd
storage class change via update is non-functional and deprecated on API side
1 parent 1b5d0b2 commit 2989128

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ require (
2323
github.com/stackitcloud/stackit-sdk-go/services/iaas v0.31.0
2424
github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v1.5.2
2525
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1
26-
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1
26+
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0
2727
github.com/stackitcloud/stackit-sdk-go/services/resourcemanager v0.17.1
2828
github.com/stackitcloud/stackit-sdk-go/services/runcommand v1.3.1
2929
github.com/stackitcloud/stackit-sdk-go/services/secretsmanager v0.13.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,8 +587,8 @@ github.com/stackitcloud/stackit-sdk-go/services/observability v0.15.0 h1:MA5i1Sc
587587
github.com/stackitcloud/stackit-sdk-go/services/observability v0.15.0/go.mod h1:tJEOi6L0le4yQZPGwalup/PZ13gqs1aCQDqlUs2cYW0=
588588
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1 h1:50n87uZn0EvSP9hJGLqd3Wm2hfqbyh7BMGGCk7axgqA=
589589
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.24.1/go.mod h1:jfguuSPa56Z5Bzs/Xg/CI37XzPo5Zn5lzC5LhfuT8Qc=
590-
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1 h1:K8vXele3U6b5urcSIpq21EkVblWfPDY3eMPSuQ48TkI=
591-
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.2.1/go.mod h1:hyhw+I19NtjKmRLcUkY4boaTxnYSPFGbpn4RxvGqH2s=
590+
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0 h1:bRTjGuRURl7Gs2eumIqW0hXTzoOBA1nWZkfcligMsZY=
591+
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v1.3.0/go.mod h1:I/2cg1SU61M+8X1UDVB154D13I2Uk0wObKvo6Je6NFs=
592592
github.com/stackitcloud/stackit-sdk-go/services/rabbitmq v0.25.1 h1:ALrDCBih8Fu8e6530KdOjuH0iMxOLntO381BbKFlTFY=
593593
github.com/stackitcloud/stackit-sdk-go/services/rabbitmq v0.25.1/go.mod h1:+qGWSehoV0Js3FalgvT/bOgPj+UqW4I7lP5s8uAxP+o=
594594
github.com/stackitcloud/stackit-sdk-go/services/redis v0.25.1 h1:8uPt82Ez34OYMOijjEYxB1zUW6kiybkt6veQKl0AL68=

internal/cmd/postgresflex/instance/update/update.go

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const (
3333
flavorIdFlag = "flavor-id"
3434
cpuFlag = "cpu"
3535
ramFlag = "ram"
36-
storageClassFlag = "storage-class"
3736
storageSizeFlag = "storage-size"
3837
versionFlag = "version"
3938
typeFlag = "type"
@@ -135,7 +134,6 @@ func configureFlags(cmd *cobra.Command) {
135134
cmd.Flags().String(flavorIdFlag, "", "ID of the flavor")
136135
cmd.Flags().Int64(cpuFlag, 0, "Number of CPUs")
137136
cmd.Flags().Int64(ramFlag, 0, "Amount of RAM (in GB)")
138-
cmd.Flags().String(storageClassFlag, "", "Storage class")
139137
cmd.Flags().Int64(storageSizeFlag, 0, "Storage size (in GB)")
140138
cmd.Flags().String(versionFlag, "", "Version")
141139
cmd.Flags().Var(flags.EnumFlag(false, "", typeFlagOptions...), typeFlag, fmt.Sprintf("Instance type, one of %q", typeFlagOptions))
@@ -155,13 +153,12 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
155153
ram := flags.FlagToInt64Pointer(p, cmd, ramFlag)
156154
acl := flags.FlagToStringSlicePointer(p, cmd, aclFlag)
157155
backupSchedule := flags.FlagToStringPointer(p, cmd, backupScheduleFlag)
158-
storageClass := flags.FlagToStringPointer(p, cmd, storageClassFlag)
159156
storageSize := flags.FlagToInt64Pointer(p, cmd, storageSizeFlag)
160157
version := flags.FlagToStringPointer(p, cmd, versionFlag)
161158
instanceType := flags.FlagToStringPointer(p, cmd, typeFlag)
162159

163160
if instanceName == nil && flavorId == nil && cpu == nil && ram == nil && acl == nil &&
164-
backupSchedule == nil && storageClass == nil && storageSize == nil && version == nil && instanceType == nil {
161+
backupSchedule == nil && storageSize == nil && version == nil && instanceType == nil {
165162
return nil, &cliErr.EmptyUpdateError{}
166163
}
167164

@@ -181,7 +178,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
181178
FlavorId: flavorId,
182179
CPU: cpu,
183180
RAM: ram,
184-
StorageClass: storageClass,
185181
StorageSize: storageSize,
186182
Version: version,
187183
Type: instanceType,
@@ -265,11 +261,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient PostgreSQLFl
265261
payloadAcl = &postgresflex.ACL{Items: model.ACL}
266262
}
267263

268-
var payloadStorage *postgresflex.Storage
264+
var payloadStorage *postgresflex.StorageUpdate
269265
if model.StorageClass != nil || model.StorageSize != nil {
270-
payloadStorage = &postgresflex.Storage{
271-
Class: model.StorageClass,
272-
Size: model.StorageSize,
266+
payloadStorage = &postgresflex.StorageUpdate{
267+
Size: model.StorageSize,
273268
}
274269
}
275270

0 commit comments

Comments
 (0)