remove routed from the updated

Author: GokceGK

docs/stackit_beta_network_update.md

@@ -16,9 +16,6 @@ stackit beta network update [flags]
   Update network with ID "xxx" with new name "network-1-new"
   $ stackit beta network update xxx --name network-1-new
 
-  Update network with ID "xxx" with routed true
-  $ stackit beta network update xxx --routed
-
   Update network with ID "xxx" with no gateway
   $ stackit beta network update --no-ipv4-gateway
 
@@ -40,7 +37,6 @@ stackit beta network update [flags]
   -n, --name string                     Network name
       --no-ipv4-gateway                 If set to true, the network doesn't have an IPv4 gateway
       --no-ipv6-gateway                 If set to true, the network doesn't have an IPv6 gateway
-      --routed                          If set to true, the network is routed and therefore accessible from other networks
 ```
 
 ### Options inherited from parent commands

internal/cmd/beta/network/update/update.go

@@ -24,7 +24,6 @@ const (
 	networkIdArg = "NETWORK_ID"
 
 	nameFlag               = "name"
-	routedFlag             = "routed"
 	ipv4DnsNameServersFlag = "ipv4-dns-name-servers"
 	ipv4GatewayFlag        = "ipv4-gateway"
 	ipv6DnsNameServersFlag = "ipv6-dns-name-servers"
@@ -37,7 +36,6 @@ type inputModel struct {
 	*globalflags.GlobalFlagModel
 	NetworkId          string
 	Name               *string
-	Routed             bool
 	IPv4DnsNameServers *[]string
 	IPv4Gateway        *string
 	IPv6DnsNameServers *[]string
@@ -57,10 +55,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				`Update network with ID "xxx" with new name "network-1-new"`,
 				`$ stackit beta network update xxx --name network-1-new`,
 			),
-			examples.NewExample(
-				`Update network with ID "xxx" with routed true`,
-				`$ stackit beta network update xxx --routed`,
-			),
 			examples.NewExample(
 				`Update network with ID "xxx" with no gateway`,
 				`$ stackit beta network update --no-ipv4-gateway`,
@@ -134,16 +128,12 @@ func NewCmd(p *print.Printer) *cobra.Command {
 
 func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().StringP(nameFlag, "n", "", "Network name")
-	cmd.Flags().Bool(routedFlag, false, "If set to true, the network is routed and therefore accessible from other networks")
 	cmd.Flags().StringSlice(ipv4DnsNameServersFlag, nil, "List of DNS name servers IPv4. Nameservers cannot be defined for routed networks")
 	cmd.Flags().String(ipv4GatewayFlag, "", "The IPv4 gateway of a network. If not specified, the first IP of the network will be assigned as the gateway")
 	cmd.Flags().StringSlice(ipv6DnsNameServersFlag, nil, "List of DNS name servers for IPv6. Nameservers cannot be defined for routed networks")
 	cmd.Flags().String(ipv6GatewayFlag, "", "The IPv6 gateway of a network. If not specified, the first IP of the network will be assigned as the gateway")
 	cmd.Flags().Bool(noIpv4GatewayFlag, false, "If set to true, the network doesn't have an IPv4 gateway")
 	cmd.Flags().Bool(noIpv6GatewayFlag, false, "If set to true, the network doesn't have an IPv6 gateway")
-
-	cmd.MarkFlagsMutuallyExclusive(routedFlag, ipv4DnsNameServersFlag)
-	cmd.MarkFlagsMutuallyExclusive(routedFlag, ipv6DnsNameServersFlag)
 }
 
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
@@ -158,7 +148,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 		GlobalFlagModel:    globalFlags,
 		Name:               flags.FlagToStringPointer(p, cmd, nameFlag),
 		NetworkId:          networkId,
-		Routed:             flags.FlagToBoolValue(p, cmd, routedFlag),
 		IPv4DnsNameServers: flags.FlagToStringSlicePointer(p, cmd, ipv4DnsNameServersFlag),
 		IPv4Gateway:        flags.FlagToStringPointer(p, cmd, ipv4GatewayFlag),
 		IPv6DnsNameServers: flags.FlagToStringSlicePointer(p, cmd, ipv6DnsNameServersFlag),
@@ -208,8 +197,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
 	}
 
 	payload := iaas.PartialUpdateNetworkPayload{
-		Name:   model.Name,
-		Routed: &model.Routed,
+		Name: model.Name,
 	}
 
 	if addressFamily.Ipv4 != nil || addressFamily.Ipv6 != nil {

internal/cmd/beta/network/update/update_test.go

@@ -38,7 +38,6 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 	flagValues := map[string]string{
 		nameFlag:               "example-network-name",
 		projectIdFlag:          testProjectId,
-		routedFlag:             "true",
 		ipv4DnsNameServersFlag: "1.1.1.0,1.1.2.0",
 		ipv4GatewayFlag:        "10.1.2.3",
 		ipv6DnsNameServersFlag: "2001:4860:4860::8888,2001:4860:4860::8844",
@@ -58,7 +57,6 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 		},
 		Name:               utils.Ptr("example-network-name"),
 		NetworkId:          testNetworkId,
-		Routed:             true,
 		IPv4DnsNameServers: utils.Ptr([]string{"1.1.1.0", "1.1.2.0"}),
 		IPv4Gateway:        utils.Ptr("10.1.2.3"),
 		IPv6DnsNameServers: utils.Ptr([]string{"2001:4860:4860::8888", "2001:4860:4860::8844"}),
@@ -81,8 +79,7 @@ func fixtureRequest(mods ...func(request *iaas.ApiPartialUpdateNetworkRequest))
 
 func fixturePayload(mods ...func(payload *iaas.PartialUpdateNetworkPayload)) iaas.PartialUpdateNetworkPayload {
 	payload := iaas.PartialUpdateNetworkPayload{
-		Name:   utils.Ptr("example-network-name"),
-		Routed: utils.Ptr(true),
+		Name: utils.Ptr("example-network-name"),
 		AddressFamily: &iaas.UpdateNetworkAddressFamily{
 			Ipv4: &iaas.UpdateNetworkIPv4Body{
 				Nameservers: utils.Ptr([]string{"1.1.1.0", "1.1.2.0"}),
@@ -221,17 +218,6 @@ func TestParseInput(t *testing.T) {
 				model.IPv6Gateway = nil
 			}),
 		},
-		{
-			description: "use routed true",
-			argValues:   fixtureArgValues(),
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues[routedFlag] = "true"
-			}),
-			isValid: true,
-			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.Routed = true
-			}),
-		},
 	}
 
 	for _, tt := range tests {