fix: consistent else if-clause for labels

marceljk · marceljk · commit 35fe8c9ff200 · 2025-02-20T10:32:39.000+01:00
diff --git a/internal/cmd/beta/public-ip/associate/associate.go b/internal/cmd/beta/public-ip/associate/associate.go
@@ -59,8 +59,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get public IP: %v", err)
 				publicIpLabel = model.PublicIpId
-			}
-			if publicIpLabel == "" {
+			} else if publicIpLabel == "" {
 				publicIpLabel = model.PublicIpId
 			}
 
diff --git a/internal/cmd/beta/public-ip/create/create.go b/internal/cmd/beta/public-ip/create/create.go
@@ -67,8 +67,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get project name: %v", err)
 				projectLabel = model.ProjectId
-			}
-			if projectLabel == "" {
+			} else if projectLabel == "" {
 				projectLabel = model.ProjectId
 			}
 
diff --git a/internal/cmd/beta/public-ip/delete/delete.go b/internal/cmd/beta/public-ip/delete/delete.go
@@ -57,8 +57,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get public IP: %v", err)
 				publicIpLabel = model.PublicIpId
-			}
-			if publicIpLabel == "" {
+			} else if publicIpLabel == "" {
 				publicIpLabel = model.PublicIpId
 			}
 
diff --git a/internal/cmd/beta/public-ip/disassociate/disassociate.go b/internal/cmd/beta/public-ip/disassociate/disassociate.go
@@ -55,8 +55,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			if err != nil {
 				p.Debug(print.ErrorLevel, "get public IP: %v", err)
 				publicIpLabel = model.PublicIpId
-			}
-			if publicIpLabel == "" {
+			} else if publicIpLabel == "" {
 				publicIpLabel = model.PublicIpId
 			}
 
diff --git a/internal/cmd/beta/public-ip/list/list.go b/internal/cmd/beta/public-ip/list/list.go
@@ -81,8 +81,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				if err != nil {
 					p.Debug(print.ErrorLevel, "get project name: %v", err)
 					projectLabel = model.ProjectId
-				}
-				if projectLabel == "" {
+				} else if projectLabel == "" {
 					projectLabel = model.ProjectId
 				}
 				p.Info("No public IPs found for project %q\n", projectLabel)

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`59`	`59`	`if err != nil {`
`60`	`60`	`p.Debug(print.ErrorLevel, "get public IP: %v", err)`
`61`	`61`	`publicIpLabel = model.PublicIpId`
`62`		`- }`
`63`		`- if publicIpLabel == "" {`
	`62`	`+ } else if publicIpLabel == "" {`
`64`	`63`	`publicIpLabel = model.PublicIpId`
`65`	`64`	`}`
`66`	`65`
Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`67`	`67`	`if err != nil {`
`68`	`68`	`p.Debug(print.ErrorLevel, "get project name: %v", err)`
`69`	`69`	`projectLabel = model.ProjectId`
`70`		`- }`
`71`		`- if projectLabel == "" {`
	`70`	`+ } else if projectLabel == "" {`
`72`	`71`	`projectLabel = model.ProjectId`
`73`	`72`	`}`
`74`	`73`
Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`57`	`57`	`if err != nil {`
`58`	`58`	`p.Debug(print.ErrorLevel, "get public IP: %v", err)`
`59`	`59`	`publicIpLabel = model.PublicIpId`
`60`		`- }`
`61`		`- if publicIpLabel == "" {`
	`60`	`+ } else if publicIpLabel == "" {`
`62`	`61`	`publicIpLabel = model.PublicIpId`
`63`	`62`	`}`
`64`	`63`
Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,7 @@ func NewCmd(p print.Printer) cobra.Command {`
`55`	`55`	`if err != nil {`
`56`	`56`	`p.Debug(print.ErrorLevel, "get public IP: %v", err)`
`57`	`57`	`publicIpLabel = model.PublicIpId`
`58`		`- }`
`59`		`- if publicIpLabel == "" {`
	`58`	`+ } else if publicIpLabel == "" {`
`60`	`59`	`publicIpLabel = model.PublicIpId`
`61`	`60`	`}`
`62`	`61`