Skip to content

Commit 5985f19

Browse files
committed
fix(cdn) review changes
- fix `ID` spelling - add missing new line at end of output - rm TODO comment
1 parent e54a176 commit 5985f19

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

internal/cmd/beta/cdn/distribution/create/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ func outputResult(p *print.Printer, outputFormat, projectLabel string, resp *cdn
330330
return fmt.Errorf("create distribution response is nil")
331331
}
332332
return p.OutputResult(outputFormat, resp, func() error {
333-
p.Outputf("Created CDN distribution for %q. Id: %s\n", projectLabel, utils.PtrString(resp.Distribution.Id))
333+
p.Outputf("Created CDN distribution for %q. ID: %s\n", projectLabel, utils.PtrString(resp.Distribution.Id))
334334
return nil
335335
})
336336
}

internal/cmd/beta/cdn/distribution/create/create_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ func TestOutputResult(t *testing.T) {
520520
Id: ptr.To("dist-1234"),
521521
},
522522
},
523-
expected: fmt.Sprintf("Created CDN distribution for %q. Id: dist-1234\n", testProjectId),
523+
expected: fmt.Sprintf("Created CDN distribution for %q. ID: dist-1234\n", testProjectId),
524524
},
525525
}
526526

internal/cmd/beta/cdn/distribution/delete/delete.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
6969
return fmt.Errorf("delete loadbalancer: %w", err)
7070
}
7171

72-
params.Printer.Outputf("CDN distribution %q deleted.", model.DistributionID)
72+
params.Printer.Outputf("CDN distribution %q deleted.\n", model.DistributionID)
7373
return nil
7474
},
7575
}

internal/cmd/beta/cdn/distribution/describe/describe.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ func buildDistributionTable(d *cdn.Distribution) tables.Table {
197197
table.AddSeparator()
198198
table.AddRow("OPTIMIZER ENABLED", optimizerEnabled)
199199
table.AddSeparator()
200-
// TODO config has yet another WAF block, left it out because the docs say to use the WAF block at the top level to determine enabled rules. There's also mode and type fields here, both left out.
201200
return table
202201
}
203202

0 commit comments

Comments
 (0)