Fix: Linter and tests

Author: marceljk

internal/cmd/config/profile/export/export.go

@@ -2,13 +2,15 @@ package export
 
 import (
 	"fmt"
-	"github.com/spf13/cobra"
+
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/config"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
+
+	"github.com/spf13/cobra"
 )
 
 const (

internal/cmd/config/profile/export/export_test.go

@@ -1,10 +1,12 @@
 package export
 
 import (
-	"github.com/google/go-cmp/cmp"
+	"testing"
+
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
-	"testing"
+
+	"github.com/google/go-cmp/cmp"
 )
 
 const (
@@ -77,7 +79,10 @@ func TestParseInput(t *testing.T) {
 			description: "no flags",
 			argsValues:  fixtureArgValues(),
 			flagValues:  map[string]string{},
-			isValid:     false,
+			isValid:     true,
+			expectedModel: fixtureInputModel(func(inputModel *inputModel) {
+				inputModel.ExportPath = ""
+			}),
 		},
 	}
 

internal/pkg/config/profiles.go

@@ -3,12 +3,14 @@ package config
 import (
 	"encoding/json"
 	"fmt"
-	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
-	"github.com/stackitcloud/stackit-cli/internal/pkg/fileutils"
-	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"os"
 	"path/filepath"
 	"regexp"
+	"strings"
+
+	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/fileutils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 )
 
 const ProfileEnvVar = "STACKIT_CLI_PROFILE"
@@ -415,32 +417,25 @@ func ExportProfile(p *print.Printer, profile, filePath string) error {
 
 	profilePath := GetProfileFolderPath(profile)
 	configFile := getConfigFilePath(profilePath)
-	exportFilePath := filePath
 
-	// Handle if exportFilePath is a directory
-	stats, err := os.Stat(exportFilePath)
-	if err == nil {
-		// If exportFilePath exists, and it is not a directory, then return an error
-		if !stats.IsDir() {
-			return &errors.FileAlreadyExistsError{Filename: exportFilePath}
-		}
-
-		exportFileName := fmt.Sprintf("%s.%s", profile, configFileExtension)
+	exportFileName := fmt.Sprintf("%s.%s", profile, configFileExtension)
+	exportFilePath := filePath
+	if !strings.HasSuffix(exportFilePath, fmt.Sprintf(".%s", configFileExtension)) {
 		exportFilePath = filepath.Join(filePath, exportFileName)
+	}
 
-		_, err = os.Stat(exportFilePath)
-		if err == nil {
-			return &errors.FileAlreadyExistsError{Filename: exportFilePath}
-		}
+	_, err = os.Stat(exportFilePath)
+	if err == nil {
+		return fmt.Errorf("file %q already exists in the export path. Delete the existing file or define a different export path", exportFileName)
 	}
 
 	err = fileutils.CopyFile(configFile, exportFilePath)
 	if err != nil {
-		return fmt.Errorf("export config file: %w", err)
+		return fmt.Errorf("export config file to %q: %w", exportFilePath, err)
 	}
 
 	if p != nil {
-		p.Debug(print.DebugLevel, "exported profile %q", profile)
+		p.Debug(print.DebugLevel, "exported profile %q to %q", profile, exportFilePath)
 	}
 
 	return nil

internal/pkg/config/profiles_test.go

@@ -190,7 +190,9 @@ func TestExportProfile(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(testDir)
+	defer func(path string) {
+		_ = os.RemoveAll(path)
+	}(testDir)
 
 	tests := []struct {
 		description string