feat(credentials): fixed linter issues

Author: bahkauv70

internal/cmd/beta/alb/credentials/create/create.go

@@ -1,6 +1,7 @@
 package create
 
 import (
+	"bytes"
 	"context"
 	"encoding/json"
 	"fmt"
@@ -110,7 +111,7 @@ func readPassword() (string, error) {
 		return "", fmt.Errorf("cannot read password: %w", err)
 	}
 	fmt.Println()
-	if string(password) != string(confirmation) {
+	if bytes.Equal(password, confirmation) {
 		return "", fmt.Errorf("the password and the confirmation do not match")
 	}
 

internal/cmd/beta/alb/credentials/create/create_test.go

@@ -18,8 +18,6 @@ type testCtxKey struct{}
 var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
 var testClient = &alb.APIClient{}
 
-const passwordFlag = "password"
-
 var (
 	testProjectId   = uuid.NewString()
 	testRegion      = "eu01"

internal/cmd/beta/alb/credentials/delete/delete.go

@@ -15,7 +15,7 @@ import (
 )
 
 const (
-	credentialRefArg = "CREDENTIAL_REF"
+	credentialRefArg = "CREDENTIAL_REF" // nolint:gosec // false alert, this are not valid credentials
 )
 
 type inputModel struct {

internal/cmd/beta/alb/credentials/delete/delete_test.go

@@ -98,9 +98,9 @@ func TestParseInput(t *testing.T) {
 			isValid:     false,
 		},
 		{
-			description:   "no flags",
-			argValues:     fixtureArgValues(),
-			flagValues:    map[string]string{
+			description: "no flags",
+			argValues:   fixtureArgValues(),
+			flagValues: map[string]string{
 				globalflags.ProjectIdFlag: testProjectId,
 				globalflags.RegionFlag:    testRegion,
 			},

internal/cmd/beta/alb/credentials/describe/describe.go

@@ -20,7 +20,7 @@ import (
 )
 
 const (
-	credentialRefArg = "CREDENTIAL_REF_ARG"
+	credentialRefArg = "CREDENTIAL_REF" // nolint:gosec // false alert, this are not valid credentials
 )
 
 type inputModel struct {
@@ -67,13 +67,9 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			return nil
 		},
 	}
-	configureFlags(cmd)
 	return cmd
 }
 
-func configureFlags(cmd *cobra.Command) {
-}
-
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
 	globalFlags := globalflags.Parse(p, cmd)
 

internal/cmd/beta/alb/credentials/list/list.go

@@ -149,7 +149,6 @@ func outputResult(p *print.Printer, outputFormat string, items []alb.Credentials
 		table.SetHeader("CREDENTIAL REF", "DISPLAYNAME", "USERNAME", "REGION")
 
 		for _, item := range items {
-
 			table.AddRow(
 				utils.PtrString(item.CredentialsRef),
 				utils.PtrString(item.DisplayName),

internal/cmd/beta/alb/credentials/list/list_test.go

@@ -110,12 +110,10 @@ func TestParseInput(t *testing.T) {
 			isValid: false,
 		},
 		{
-			description: "label selector empty",
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-			}),
-			isValid: true,
-			expectedModel: fixtureInputModel(func(inputModel *inputModel) {
-			}),
+			description:   "label selector empty",
+			flagValues:    fixtureFlagValues(),
+			isValid:       true,
+			expectedModel: fixtureInputModel(),
 		},
 	}
 

internal/cmd/beta/alb/credentials/update/update.go

@@ -1,6 +1,7 @@
 package update
 
 import (
+	"bytes"
 	"context"
 	"encoding/json"
 	"fmt"
@@ -20,13 +21,13 @@ import (
 	"github.com/stackitcloud/stackit-sdk-go/services/alb"
 )
 
-const passwordEnv = "ALB_CREDENTIALS_PASSWORD"
+const passwordEnv = "ALB_CREDENTIALS_PASSWORD" //nolint:gosec // false alert, this are not valid credentials
 
 const (
 	usernameFlag     = "username"
 	displaynameFlag  = "displayname"
 	passwordFlag     = "password"
-	credentialRefArg = "CREDENTIAL_REF_ARG"
+	credentialRefArg = "CREDENTIAL_REF_ARG" //nolint:gosec // false alert, this are not valid credentials
 )
 
 type inputModel struct {
@@ -99,7 +100,6 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().StringP(usernameFlag, "u", "", "the username for the credentials")
 	cmd.Flags().StringP(displaynameFlag, "d", "", "the displayname for the credentials")
 	cmd.Flags().BoolP(passwordFlag, "w", false, "change the password for the credentials")
-
 }
 
 func buildRequest(ctx context.Context, model *inputModel, apiClient *alb.APIClient, readPassword func() (string, error)) (req alb.ApiUpdateCredentialsRequest, err error) {
@@ -138,14 +138,13 @@ func readPassword() (string, error) {
 		return "", fmt.Errorf("cannot read password: %w", err)
 	}
 	fmt.Println()
-	if string(password) != string(confirmation) {
+	if bytes.Equal(password, confirmation) {
 		return "", fmt.Errorf("the password and the confirmation do not match")
 	}
 
 	return string(password), nil
 }
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) inputModel {
-
 	model := inputModel{
 		GlobalFlagModel: globalflags.Parse(p, cmd),
 		Username:        flags.FlagToStringPointer(p, cmd, usernameFlag),