removed risky delete output

Author: Jan Sternagel

internal/cmd/beta/kms/keyring/delete/delete.go

@@ -2,10 +2,8 @@ package delete
 
 import (
 	"context"
-	"encoding/json"
 	"fmt"
 
-	"github.com/goccy/go-yaml"
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
@@ -76,12 +74,9 @@ func NewCmd(params *params.CmdParams) *cobra.Command {
 
 			// Wait for async operation not relevant. Key ring deletion is synchronous.
 
-			// Get the key ring so it can be outputted in the state it is after the deletion.
-			resp, err := apiClient.GetKeyRingExecute(ctx, model.ProjectId, model.Region, model.KeyRingId)
-			if err != nil {
-				params.Printer.Debug(print.ErrorLevel, "get KMS Key Ring: %w", err)
-			}
-			return outputResult(params.Printer, model.OutputFormat, resp)
+			// Don't output anything. It's a deletion.
+			params.Printer.Info("Deleted the key ring %q\n", keyRingLabel)
+			return nil
 		},
 	}
 	return cmd
@@ -116,28 +111,3 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *kms.APIClie
 	req := apiClient.DeleteKeyRing(ctx, model.ProjectId, model.Region, model.KeyRingId)
 	return req
 }
-
-func outputResult(p *print.Printer, outputFormat string, resp *kms.KeyRing) error {
-	if resp == nil {
-		return fmt.Errorf("response from 'GetKeyExecute()' is nil")
-	}
-
-	switch outputFormat {
-	case print.JSONOutputFormat:
-		details, err := json.MarshalIndent(resp, "", "  ")
-		if err != nil {
-			return fmt.Errorf("marshal output to JSON: %w", err)
-		}
-		p.Outputln(string(details))
-	case print.YAMLOutputFormat:
-		details, err := yaml.MarshalWithOptions(resp, yaml.IndentSequence(true), yaml.UseJSONMarshaler())
-		if err != nil {
-			return fmt.Errorf("marshal output to YAML: %w", err)
-		}
-		p.Outputln(string(details))
-
-	default:
-		p.Outputf("Deleted key ring: %s\n", utils.PtrString(resp.DisplayName))
-	}
-	return nil
-}

internal/cmd/beta/kms/keyring/delete/delete_test.go

@@ -210,46 +210,3 @@ func TestBuildRequest(t *testing.T) {
 		})
 	}
 }
-
-func TestOutputResult(t *testing.T) {
-	tests := []struct {
-		description  string
-		wantErr      bool
-		outputFormat string
-		resp         *kms.KeyRing
-	}{
-		{
-			description: "nil response",
-			resp:        nil,
-			wantErr:     true,
-		},
-		{
-			description: "default output",
-			resp:        &kms.KeyRing{},
-			wantErr:     false,
-		},
-		{
-			description:  "json output",
-			outputFormat: print.JSONOutputFormat,
-			resp:         &kms.KeyRing{},
-			wantErr:      false,
-		},
-		{
-			description:  "yaml output",
-			outputFormat: print.YAMLOutputFormat,
-			resp:         &kms.KeyRing{},
-			wantErr:      false,
-		},
-	}
-
-	p := print.NewPrinter()
-	p.Cmd = NewCmd(&params.CmdParams{Printer: p})
-	for _, tt := range tests {
-		t.Run(tt.description, func(t *testing.T) {
-			err := outputResult(p, tt.outputFormat, tt.resp)
-			if (err != nil) != tt.wantErr {
-				t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
-			}
-		})
-	}
-}