feature: fix review comments

Author: bahkauv70

internal/cmd/beta/security-group/create/create.go

@@ -108,8 +108,8 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
 	for _, label := range flags.FlagToStringSliceValue(p, cmd, labelsFlag) {
 		parts := strings.Split(label, "=")
 		if len(parts) != 2 {
-			return nil, &errors.ArgValidationError{
-				Arg:     labelsFlag,
+			return nil, &errors.FlagValidationError{
+				Flag:    labelsFlag,
 				Details: "invalid label declaration. Must be in the form <key>=<value>",
 			}
 		}

internal/cmd/beta/security-group/update/update.go

@@ -28,6 +28,12 @@ type inputModel struct {
 
 const argNameGroupId = "GROUP_ID"
 
+const (
+	nameArg        = "name"
+	descriptionArg = "description"
+	labelsArg      = "labels"
+)
+
 func NewCmd(p *print.Printer) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "update",
@@ -75,9 +81,9 @@ func NewCmd(p *print.Printer) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	cmd.Flags().String("name", "", "the name of the security group. Must be <= 63 chars")
-	cmd.Flags().String("description", "", "an optional description of the security group. Must be <= 127 chars")
-	cmd.Flags().StringSlice("labels", nil, "Labels are key-value string pairs which can be attached to a network-interface. E.g. '--labels key1=value1,key2=value2,...'")
+	cmd.Flags().String(nameArg, "", "the name of the security group. Must be <= 63 chars")
+	cmd.Flags().String(descriptionArg, "", "an optional description of the security group. Must be <= 127 chars")
+	cmd.Flags().StringSlice(labelsArg, nil, "Labels are key-value string pairs which can be attached to a network-interface. E.g. '--labels key1=value1,key2=value2,...'")
 }
 
 func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputModel, error) {
@@ -104,27 +110,27 @@ func parseInput(p *print.Printer, cmd *cobra.Command, cliArgs []string) (*inputM
 	}
 	model.SecurityGroupId = cliArgs[0]
 
-	if cmd.Flags().Lookup("name").Changed {
-		name := flags.FlagToStringValue(p, cmd, "name")
+	if cmd.Flags().Lookup(nameArg).Changed {
+		name := flags.FlagToStringValue(p, cmd, nameArg)
 		model.Name = &name
 	}
 
-	if cmd.Flags().Lookup("labels").Changed {
+	if cmd.Flags().Lookup(labelsArg).Changed {
 		labels := make(map[string]any)
-		for _, label := range flags.FlagToStringSliceValue(p, cmd, "labels") {
+		for _, label := range flags.FlagToStringSliceValue(p, cmd, labelsArg) {
 			parts := strings.Split(label, "=")
 			if len(parts) != 2 {
 				return nil, &errors.ArgValidationError{
-					Arg:     "labels",
+					Arg:     labelsArg,
 					Details: "invalid label declaration. Must be in the form <key>=<value>",
 				}
 			}
 			labels[parts[0]] = parts[1]
 		}
 		model.Labels = &labels
 	}
-	if cmd.Flags().Lookup("description").Changed {
-		description := flags.FlagToStringValue(p, cmd, "description")
+	if cmd.Flags().Lookup(descriptionArg).Changed {
+		description := flags.FlagToStringValue(p, cmd, descriptionArg)
 		model.Description = &description
 	}
 

internal/cmd/beta/security-group/update/update_test.go

@@ -33,10 +33,10 @@ var (
 
 func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
 	flagValues := map[string]string{
-		projectIdFlag: testProjectId,
-		"description": testDescription,
-		"labels":      "fooKey=fooValue,barKey=barValue,bazKey=bazValue",
-		"name":        testName,
+		projectIdFlag:  testProjectId,
+		descriptionArg: testDescription,
+		labelsArg:      "fooKey=fooValue,barKey=barValue,bazKey=bazValue",
+		nameArg:        testName,
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -126,7 +126,7 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "no name passed",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, "name")
+				delete(flagValues, nameArg)
 			}),
 			args: testGroupId,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
@@ -137,7 +137,7 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "no description passed",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, "description")
+				delete(flagValues, descriptionArg)
 			}),
 			args: testGroupId,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
@@ -148,7 +148,7 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "no labels",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, "labels")
+				delete(flagValues, labelsArg)
 			}),
 			args: testGroupId,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
@@ -159,7 +159,7 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "single label",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues["labels"] = "foo=bar"
+				flagValues[labelsArg] = "foo=bar"
 			}),
 			args:    testGroupId,
 			isValid: true,
@@ -172,15 +172,15 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "malformed labels 1",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues["labels"] = "foo=bar=baz"
+				flagValues[labelsArg] = "foo=bar=baz"
 			}),
 			args:    testGroupId,
 			isValid: false,
 		},
 		{
 			description: "malformed labels 2",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues["labels"] = "foobarbaz"
+				flagValues[labelsArg] = "foobarbaz"
 			}),
 			args:    testGroupId,
 			isValid: false,