Changed export --file-path behaviour.

- When --file-path is set, it does not add a default name and the user needs to provide the whole export path
- When --file-path is empty, it adds a default name

Author: marceljk

docs/stackit_config_profile_export.md

@@ -13,7 +13,7 @@ stackit config profile export PROFILE_NAME [flags]
 ### Examples
 
 ```
-  Export a profile with name "PROFILE_NAME" to the current path
+  Export a profile with name "PROFILE_NAME" to a file in your current directory
   $ stackit config profile export PROFILE_NAME
 
   Export a profile with name "PROFILE_NAME"" to a specific file path FILE_PATH
@@ -23,7 +23,7 @@ stackit config profile export PROFILE_NAME [flags]
 ### Options
 
 ```
-      --file-path string   Path where the config should be saved. E.g. '--file-path ~/config.json', '--file-path ~/'
+  -f, --file-path string   If set, writes the config to the given. If unset, writes the config to you current directory with the name of the profile. E.g. '--file-path ~/my-config.json', '--file-path ~/'
   -h, --help               Help for "stackit config profile export"
 ```
 

internal/cmd/config/profile/export/export.go

@@ -3,7 +3,6 @@ package export
 import (
 	"fmt"
 	"path/filepath"
-	"strings"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/config"
@@ -66,7 +65,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	cmd.Flags().StringP(filePathFlag, "f", "", "If set, writes the payload to the given. If unset, writes the payload to you current directory with the name of the profile. E.g. '--file-path ~/my-config.json', '--file-path ~/'")
+	cmd.Flags().StringP(filePathFlag, "f", "", "If set, writes the config to the given. If unset, writes the config to you current directory with the name of the profile. E.g. '--file-path ~/my-config.json', '--file-path ~/'")
 }
 
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
@@ -80,7 +79,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 	}
 
 	// If filePath contains does not contain a file name, then add a default name
-	if !strings.HasSuffix(model.FilePath, fmt.Sprintf(".%s", configFileExtension)) {
+	if model.FilePath == "" {
 		exportFileName := fmt.Sprintf("%s.%s", model.ProfileName, configFileExtension)
 		model.FilePath = filepath.Join(model.FilePath, exportFileName)
 	}

internal/cmd/config/profile/export/export_test.go

@@ -85,6 +85,18 @@ func TestParseInput(t *testing.T) {
 				inputModel.FilePath = fmt.Sprintf("%s.json", testProfileArg)
 			}),
 		},
+		{
+			description: "custom file-path without file extension",
+			argsValues:  fixtureArgValues(),
+			flagValues: fixtureFlagValues(
+				func(flagValues map[string]string) {
+					flagValues[filePathFlag] = "./my-exported-config"
+				}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(inputModel *inputModel) {
+				inputModel.FilePath = "./my-exported-config"
+			}),
+		},
 	}
 
 	for _, tt := range tests {

internal/pkg/config/profiles.go

@@ -6,7 +6,6 @@ import (
 	"os"
 	"path/filepath"
 	"regexp"
-	"strings"
 
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/fileutils"
@@ -400,7 +399,7 @@ func ImportProfile(p *print.Printer, profileName, config string, setAsActive boo
 }
 
 // ExportProfile exports a profile configuration
-// Is exports the profile to the exportPath. The exportPath must contain in the suffix `.json` as file extension
+// Is exports the profile to the exportPath. The exportPath must contain the filename.
 func ExportProfile(p *print.Printer, profile, exportPath string) error {
 	err := ValidateProfile(profile)
 	if err != nil {
@@ -418,10 +417,6 @@ func ExportProfile(p *print.Printer, profile, exportPath string) error {
 	profilePath := GetProfileFolderPath(profile)
 	configFile := getConfigFilePath(profilePath)
 
-	if !strings.HasSuffix(exportPath, fmt.Sprintf(".%s", configFileExtension)) {
-		return fmt.Errorf("export file name must end with '.%s'", configFileExtension)
-	}
-
 	_, err = os.Stat(exportPath)
 	if err == nil {
 		return &errors.FileAlreadyExistsError{Filename: exportPath}

internal/pkg/config/profiles_test.go

@@ -249,6 +249,12 @@ func TestExportProfile(t *testing.T) {
 			filePath:    filepath.Join(testDir, "invalid", "path", fmt.Sprintf("custom-name.%s", configFileExtension)),
 			isValid:     false,
 		},
+		{
+			description: "export without file extension",
+			profile:     profileName,
+			filePath:    filepath.Join(testDir, "file-without-extension"),
+			isValid:     true,
+		},
 	}
 
 	for _, tt := range tests {