fix: added testcases for flag groups

Author: bahkauv70

internal/cmd/beta/image/create/create_test.go

@@ -233,6 +233,32 @@ func TestParseInput(t *testing.T) {
 				}
 			}),
 		},
+		{
+			description: "only rescue bus is invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueDeviceFlag)
+			}),
+			isValid: false,
+		},
+		{
+			description: "only rescue device is invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueBusFlag)
+			}),
+			isValid: false,
+		},
+		{
+			description: "no rescue device and no bus is valid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueBusFlag)
+				delete(flagValues, rescueDeviceFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.Config.RescueBus = nil
+				model.Config.RescueDevice = nil
+			}),
+		},
 	}
 
 	for _, tt := range tests {
@@ -253,6 +279,13 @@ func TestParseInput(t *testing.T) {
 				}
 			}
 
+			if err := cmd.ValidateFlagGroups(); err != nil {
+				if !tt.isValid {
+					return
+				}
+				t.Fatalf("error validating flag groups: %v", err)
+			}
+
 			if err := cmd.ValidateRequiredFlags(); err != nil {
 				if !tt.isValid {
 					return

internal/cmd/beta/image/update/update_test.go

@@ -268,6 +268,35 @@ func TestParseInput(t *testing.T) {
 			args:        []string{uuid.NewString(), uuid.NewString()},
 			isValid:     false,
 		},
+		{
+			description: "only rescue bus is invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueDeviceFlag)
+			}),
+			args:    []string{testImageId[0]},
+			isValid: false,
+		},
+		{
+			description: "only rescue device is invalid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueBusFlag)
+			}),
+			args:    []string{testImageId[0]},
+			isValid: false,
+		},
+		{
+			description: "no rescue device and no bus is valid",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, rescueBusFlag)
+				delete(flagValues, rescueDeviceFlag)
+			}),
+			isValid: true,
+			args:    []string{testImageId[0]},
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.Config.RescueBus = nil
+				model.Config.RescueDevice = nil
+			}),
+		},
 	}
 
 	for _, tt := range tests {
@@ -294,6 +323,13 @@ func TestParseInput(t *testing.T) {
 				t.Fatalf("error validating flags: %v", err)
 			}
 
+			if err := cmd.ValidateFlagGroups(); err != nil {
+				if !tt.isValid {
+					return
+				}
+				t.Fatalf("error validating flag groups: %v", err)
+			}
+
 			if err := cmd.ValidateArgs(tt.args); err != nil {
 				if !tt.isValid {
 					return