fix(cdn) apply review comments

- replace single char names with more descriptive ones
- remove predefined mod functions
- deduplicate ParseOriginRequestHeaders and test it
- deduplicate ParseGeofencing and test it
- add test FlagTo* funcs

Author: cgoetz-inovex

internal/cmd/beta/cdn/distribution/create/create.go

@@ -3,7 +3,6 @@ package create
 import (
 	"context"
 	"fmt"
-	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
@@ -15,6 +14,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/client"
+	cdnUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/cdn/utils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	sdkUtils "github.com/stackitcloud/stackit-sdk-go/core/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/cdn"
@@ -203,13 +203,13 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 		var geofencing *map[string][]string
 		geofencingInput := flags.FlagToStringArrayValue(p, cmd, flagHTTPGeofencing)
 		if geofencingInput != nil {
-			geofencing = parseGeofencing(p, geofencingInput)
+			geofencing = cdnUtils.ParseGeofencing(p, geofencingInput)
 		}
 
 		var originRequestHeaders *map[string]string
 		originRequestHeadersInput := flags.FlagToStringSliceValue(p, cmd, flagHTTPOriginRequestHeaders)
 		if originRequestHeadersInput != nil {
-			originRequestHeaders = parseOriginRequestHeaders(p, originRequestHeadersInput)
+			originRequestHeaders = cdnUtils.ParseOriginRequestHeaders(p, originRequestHeadersInput)
 		}
 
 		http = &httpInputModel{
@@ -265,39 +265,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return &model, nil
 }
 
-func parseGeofencing(p *print.Printer, geofencingInput []string) *map[string][]string { //nolint:gocritic // ptrToRefParam is nice here because of awkward SDK API
-	geofencing := make(map[string][]string)
-	for _, in := range geofencingInput {
-		firstSpace := strings.IndexRune(in, ' ')
-		if firstSpace == -1 {
-			p.Debug(print.ErrorLevel, "invalid geofencing entry (no space found): %q", in)
-			continue
-		}
-		urlPart := in[:firstSpace]
-		countriesPart := in[firstSpace+1:]
-		geofencing[urlPart] = nil
-		countries := strings.Split(countriesPart, ",")
-		for _, country := range countries {
-			country = strings.TrimSpace(country)
-			geofencing[urlPart] = append(geofencing[urlPart], country)
-		}
-	}
-	return &geofencing
-}
-
-func parseOriginRequestHeaders(p *print.Printer, originRequestHeadersInput []string) *map[string]string { //nolint:gocritic // ptrToRefParam is nice here because of awkward SDK API
-	originRequestHeaders := make(map[string]string)
-	for _, in := range originRequestHeadersInput {
-		parts := strings.Split(in, ":")
-		if len(parts) != 2 {
-			p.Debug(print.ErrorLevel, "invalid origin request header entry (no colon found): %q", in)
-			continue
-		}
-		originRequestHeaders[strings.TrimSpace(parts[0])] = strings.TrimSpace(parts[1])
-	}
-	return &originRequestHeaders
-}
-
 func buildRequest(ctx context.Context, model *inputModel, apiClient *cdn.APIClient) cdn.ApiCreateDistributionRequest {
 	req := apiClient.CreateDistribution(ctx, model.ProjectId)
 	var backend cdn.CreateDistributionPayloadGetBackendArgType

internal/cmd/beta/cdn/distribution/describe/describe_test.go

@@ -28,7 +28,7 @@ var (
 	testTime           = time.Time{}
 )
 
-func fixtureFlagValues(mods ...func(m map[string]string)) map[string]string {
+func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
 	flagValues := map[string]string{
 		globalflags.ProjectIdFlag: testProjectID,
 	}
@@ -38,7 +38,7 @@ func fixtureFlagValues(mods ...func(m map[string]string)) map[string]string {
 	return flagValues
 }
 
-func fixtureInputModel(mods ...func(m *inputModel)) *inputModel {
+func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 	model := &inputModel{
 		GlobalFlagModel: &globalflags.GlobalFlagModel{
 			ProjectId: testProjectID,
@@ -53,7 +53,7 @@ func fixtureInputModel(mods ...func(m *inputModel)) *inputModel {
 	return model
 }
 
-func fixtureResponse(mods ...func(r *cdn.GetDistributionResponse)) *cdn.GetDistributionResponse {
+func fixtureResponse(mods ...func(resp *cdn.GetDistributionResponse)) *cdn.GetDistributionResponse {
 	response := &cdn.GetDistributionResponse{
 		Distribution: &cdn.Distribution{
 			Config: &cdn.Config{
@@ -133,12 +133,12 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "with WAF",
 			args:        []string{testDistributionID},
-			flags: fixtureFlagValues(func(m map[string]string) {
-				m[flagWithWaf] = "true"
+			flags: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[flagWithWaf] = "true"
 			}),
 			isValid: true,
-			expected: fixtureInputModel(func(m *inputModel) {
-				m.WithWAF = true
+			expected: fixtureInputModel(func(model *inputModel) {
+				model.WithWAF = true
 			}),
 		},
 	}
@@ -162,8 +162,8 @@ func TestBuildRequest(t *testing.T) {
 		},
 		{
 			description: "with WAF",
-			model: fixtureInputModel(func(m *inputModel) {
-				m.WithWAF = true
+			model: fixtureInputModel(func(model *inputModel) {
+				model.WithWAF = true
 			}),
 			expected: testClient.GetDistribution(testCtx, testProjectID, testDistributionID).WithWafStatus(true),
 		},

internal/cmd/beta/cdn/distribution/list/list.go

@@ -128,9 +128,11 @@ func outputResult(p *print.Printer, outputFormat string, distributions []cdn.Dis
 
 		table := tables.NewTable()
 		table.SetHeader("ID", "REGIONS", "STATUS")
-		for i := range distributions {
-			d := &distributions[i]
-			joinedRegions := strings.Join(sdkUtils.EnumSliceToStringSlice(*d.Config.Regions), ", ")
+		for _, d := range distributions {
+			var joinedRegions string
+			if d.Config != nil && d.Config.Regions != nil {
+				joinedRegions = strings.Join(sdkUtils.EnumSliceToStringSlice(*d.Config.Regions), ", ")
+			}
 			table.AddRow(
 				utils.PtrString(d.Id),
 				joinedRegions,