remove the flag control (api errors are sufficient)

Author: GokceGK

internal/cmd/beta/security-group/rule/create/create.go

@@ -163,28 +163,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
 		ProtocolName:          flags.FlagToStringPointer(p, cmd, protocolNameFlag),
 	}
 
-	if model.ProtocolName != nil {
-		if *model.ProtocolName == "icmp" || *model.ProtocolName == "ipv6-icmp" {
-			if model.PortRangeMin != nil || model.PortRangeMax != nil {
-				return nil, &cliErr.SecurityGroupRuleProtocolPortRangeConflictError{
-					Cmd: cmd,
-				}
-			}
-		} else {
-			if model.IcmpParameterCode != nil || model.IcmpParameterType != nil {
-				return nil, &cliErr.SecurityGroupRuleProtocolParametersConflictError{
-					Cmd: cmd,
-				}
-			}
-		}
-	}
-
-	if (model.PortRangeMin != nil || model.PortRangeMax != nil) && (model.ProtocolNumber == nil && model.ProtocolName == nil) {
-		return nil, &cliErr.SecurityGroupRuleProtocolMissingForPortRangeError{
-			Cmd: cmd,
-		}
-	}
-
 	if p.IsVerbosityDebug() {
 		modelStr, err := print.BuildDebugStrFromInputModel(model)
 		if err != nil {

internal/cmd/beta/security-group/rule/create/create_test.go

@@ -176,13 +176,6 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: false,
 		},
-		{
-			description: "protocol is icmp and port range values are provided",
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				delete(flagValues, protocolNumberFlag)
-			}),
-			isValid: false,
-		},
 		{
 			description: "protocol is not icmp and port range values are provided",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
@@ -199,14 +192,6 @@ func TestParseInput(t *testing.T) {
 				model.ProtocolNumber = nil
 			}),
 		},
-		{
-			description: "protocol is not icmp and icmp parameters are provided",
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues[protocolNameFlag] = "not-icmp"
-				delete(flagValues, protocolNumberFlag)
-			}),
-			isValid: false,
-		},
 		{
 			description: "no values",
 			flagValues:  map[string]string{},

internal/pkg/errors/errors.go

@@ -147,41 +147,11 @@ To enable it, run:
 
 	IAAS_SERVER_MISSING_IMAGE_OR_VOLUME_FLAGS = `Either "image-id" or "boot-volume-source-type" and "boot-volume-source-id" flags must be provided.`
 
-	IAAS_SECURITY_GROUP_RULE_PROTOCOL_PORT_RANGE_CONFLICT = `"port-range-min" and "port-range-max" attributes can't be provided if "protocol-name" is set to "icmp" or "ipv6-icmp"`
-
-	IAAS_SECURITY_GROUP_RULE_PROTOCOL_PARAMETERS_CONFLICT = `"icmp-parameter-code" and "icmp-parameter-type" attributes can't be provided if "protocol-name" is not "icmp" or "ipv6-icmp"`
-
-	IAAS_SECURITY_GROUP_RULE_PROTOCOL_MISSING_FOR_PORT_RANGE = `"protocol-name" or "protocol-number" must be provided if "port-range-min" and "port-range-max" attributes are given`
-
 	IAAS_SERVER_NIC_ATTACH_MISSING_NIC_ID = `The "network-interface-id" flag must be provided if the "create" flag is not provided.`
 
 	IAAS_SERVER_NIC_DETACH_MISSING_NIC_ID = `The "network-interface-id" flag must be provided if the "delete" flag is not provided.`
 )
 
-type SecurityGroupRuleProtocolMissingForPortRangeError struct {
-	Cmd *cobra.Command
-}
-
-func (e *SecurityGroupRuleProtocolMissingForPortRangeError) Error() string {
-	return IAAS_SECURITY_GROUP_RULE_PROTOCOL_MISSING_FOR_PORT_RANGE
-}
-
-type SecurityGroupRuleProtocolParametersConflictError struct {
-	Cmd *cobra.Command
-}
-
-func (e *SecurityGroupRuleProtocolParametersConflictError) Error() string {
-	return IAAS_SECURITY_GROUP_RULE_PROTOCOL_PARAMETERS_CONFLICT
-}
-
-type SecurityGroupRuleProtocolPortRangeConflictError struct {
-	Cmd *cobra.Command
-}
-
-func (e *SecurityGroupRuleProtocolPortRangeConflictError) Error() string {
-	return IAAS_SECURITY_GROUP_RULE_PROTOCOL_PORT_RANGE_CONFLICT
-}
-
 type ServerNicAttachMissingNicIdError struct {
 	Cmd *cobra.Command
 }