Skip to content

Commit d2f0798

Browse files
committed
changed labels format
1 parent 15dcd74 commit d2f0798

File tree

2 files changed

+24
-5
lines changed

2 files changed

+24
-5
lines changed

internal/cmd/volume/backup/describe/describe.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7+
"strings"
78

89
"github.com/goccy/go-yaml"
910
"github.com/spf13/cobra"
@@ -127,7 +128,7 @@ func outputResult(p *print.Printer, outputFormat string, backup *iaas.Backup) er
127128
table.AddSeparator()
128129
table.AddRow("NAME", utils.PtrString(backup.Name))
129130
table.AddSeparator()
130-
table.AddRow("SIZE", utils.PtrByteSizeDefault((*int64)(backup.Size), ""))
131+
table.AddRow("SIZE", utils.PtrByteSizeDefault(backup.Size, ""))
131132
table.AddSeparator()
132133
table.AddRow("STATUS", utils.PtrString(backup.Status))
133134
table.AddSeparator()
@@ -137,8 +138,16 @@ func outputResult(p *print.Printer, outputFormat string, backup *iaas.Backup) er
137138
table.AddSeparator()
138139
table.AddRow("AVAILABILITY ZONE", utils.PtrString(backup.AvailabilityZone))
139140
table.AddSeparator()
140-
table.AddRow("LABELS", utils.PtrStringDefault(backup.Labels, ""))
141-
table.AddSeparator()
141+
142+
if backup.Labels != nil && len(*backup.Labels) > 0 {
143+
var labels []string
144+
for key, value := range *backup.Labels {
145+
labels = append(labels, fmt.Sprintf("%s: %s", key, value))
146+
}
147+
table.AddRow("LABELS", strings.Join(labels, "\n"))
148+
table.AddSeparator()
149+
}
150+
142151
table.AddRow("CREATED AT", utils.ConvertTimePToDateTimeString(backup.CreatedAt))
143152
table.AddSeparator()
144153
table.AddRow("UPDATED AT", utils.ConvertTimePToDateTimeString(backup.UpdatedAt))

internal/cmd/volume/backup/list/list.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7+
"strings"
78

89
"github.com/goccy/go-yaml"
910
"github.com/spf13/cobra"
@@ -171,15 +172,24 @@ func outputResult(p *print.Printer, outputFormat string, backups []iaas.Backup)
171172
table.SetHeader("ID", "NAME", "SIZE", "STATUS", "SNAPSHOT ID", "VOLUME ID", "AVAILABILITY ZONE", "LABELS", "CREATED AT", "UPDATED AT")
172173

173174
for _, backup := range backups {
175+
var labelsString string
176+
if backup.Labels != nil {
177+
var labels []string
178+
for key, value := range *backup.Labels {
179+
labels = append(labels, fmt.Sprintf("%s: %s", key, value))
180+
}
181+
labelsString = strings.Join(labels, ", ")
182+
}
183+
174184
table.AddRow(
175185
utils.PtrString(backup.Id),
176186
utils.PtrString(backup.Name),
177-
utils.PtrByteSizeDefault((*int64)(backup.Size), ""),
187+
utils.PtrByteSizeDefault(backup.Size, ""),
178188
utils.PtrString(backup.Status),
179189
utils.PtrString(backup.SnapshotId),
180190
utils.PtrString(backup.VolumeId),
181191
utils.PtrString(backup.AvailabilityZone),
182-
utils.PtrStringDefault(backup.Labels, ""),
192+
labelsString,
183193
utils.ConvertTimePToDateTimeString(backup.CreatedAt),
184194
utils.ConvertTimePToDateTimeString(backup.UpdatedAt),
185195
)

0 commit comments

Comments
 (0)