added option to update system routes on rt

Author: h3adex

internal/cmd/routingtable/update/update.go

@@ -22,6 +22,7 @@ const (
 	nameFlag             = "name"
 	networkAreaIdFlag    = "network-area-id"
 	nonDynamicRoutesFlag = "non-dynamic-routes"
+	nonSystemRoutesFlag  = "non-system-routes"
 	organizationIdFlag   = "organization-id"
 	routingTableIdArg    = "ROUTING_TABLE_ID"
 )
@@ -31,6 +32,7 @@ type inputModel struct {
 	OrganizationId   string
 	NetworkAreaId    string
 	NonDynamicRoutes bool
+	NonSystemRoutes  bool
 	RoutingTableId   string
 	Description      *string
 	Labels           *map[string]string
@@ -60,6 +62,10 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 				`Disables the dynamic routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"`,
 				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --non-dynamic-routes",
 			),
+			examples.NewExample(
+				`Disables the system routes of a routing-table with ID "xxx" in organization with ID "yyy" and network-area with ID "zzz"`,
+				"$ stackit routing-table update xxx --organization-id yyy --network-area-id zzz --non-system-routes",
+			),
 		),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := context.Background()
@@ -101,6 +107,7 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().StringToString(labelFlag, nil, "Key=value labels")
 	cmd.Flags().Var(flags.UUIDFlag(), networkAreaIdFlag, "Network-Area ID")
 	cmd.Flags().Bool(nonDynamicRoutesFlag, false, "If true, preventing dynamic routes from propagating to the routing-table.")
+	cmd.Flags().Bool(nonSystemRoutesFlag, false, "If true, automatically disables routes for project-to-project communication.")
 	cmd.Flags().Var(flags.UUIDFlag(), organizationIdFlag, "Organization ID")
 
 	err := flags.MarkFlagsRequired(cmd, organizationIdFlag, networkAreaIdFlag)
@@ -119,6 +126,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 		Name:             flags.FlagToStringPointer(p, cmd, nameFlag),
 		NetworkAreaId:    flags.FlagToStringValue(p, cmd, networkAreaIdFlag),
 		NonDynamicRoutes: flags.FlagToBoolValue(p, cmd, nonDynamicRoutesFlag),
+		NonSystemRoutes:  flags.FlagToBoolValue(p, cmd, nonSystemRoutesFlag),
 		OrganizationId:   flags.FlagToStringValue(p, cmd, organizationIdFlag),
 		RoutingTableId:   routeTableId,
 	}
@@ -152,12 +160,14 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
 	)
 
 	dynamicRoutes := !model.NonDynamicRoutes
+	systemRoutes := !model.NonSystemRoutes
 
 	payload := iaas.UpdateRoutingTableOfAreaPayload{
 		Labels:        utils.ConvertStringMapToInterfaceMap(model.Labels),
 		Name:          model.Name,
 		Description:   model.Description,
 		DynamicRoutes: &dynamicRoutes,
+		SystemRoutes:  &systemRoutes,
 	}
 
 	return req.UpdateRoutingTableOfAreaPayload(payload)

internal/cmd/routingtable/update/update_test.go

@@ -93,6 +93,7 @@ func fixtureRequest(mods ...func(request *iaas.ApiUpdateRoutingTableOfAreaReques
 		Name:          utils.Ptr(testRoutingTableName),
 		Description:   utils.Ptr(testRoutingTableDescription),
 		DynamicRoutes: utils.Ptr(true),
+		SystemRoutes:  utils.Ptr(true),
 	}
 
 	req = req.UpdateRoutingTableOfAreaPayload(payload)
@@ -132,6 +133,18 @@ func TestParseInput(t *testing.T) {
 				model.RoutingTableId = testRoutingTableId
 			}),
 		},
+		{
+			description: "system routes disabled",
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				flagValues[nonSystemRoutesFlag] = "true"
+			}),
+			argValues: fixtureArgValues(),
+			isValid:   true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.NonSystemRoutes = true
+				model.RoutingTableId = testRoutingTableId
+			}),
+		},
 		{
 			description: "no values",
 			argValues:   []string{},
@@ -216,6 +229,7 @@ func TestBuildRequest(t *testing.T) {
 					Name:          utils.Ptr(testRoutingTableName),
 					Description:   utils.Ptr(testRoutingTableDescription),
 					DynamicRoutes: utils.Ptr(true),
+					SystemRoutes:  utils.Ptr(true),
 				})
 			}),
 		},
@@ -231,6 +245,7 @@ func TestBuildRequest(t *testing.T) {
 					Name:          nil,
 					Description:   utils.Ptr(testRoutingTableDescription),
 					DynamicRoutes: utils.Ptr(true),
+					SystemRoutes:  utils.Ptr(true),
 				})
 			}),
 		},
@@ -246,6 +261,7 @@ func TestBuildRequest(t *testing.T) {
 					Name:          utils.Ptr(testRoutingTableName),
 					Description:   nil,
 					DynamicRoutes: utils.Ptr(true),
+					SystemRoutes:  utils.Ptr(true),
 				})
 			}),
 		},
@@ -261,6 +277,23 @@ func TestBuildRequest(t *testing.T) {
 					Name:          utils.Ptr(testRoutingTableName),
 					Description:   utils.Ptr(testRoutingTableDescription),
 					DynamicRoutes: utils.Ptr(false),
+					SystemRoutes:  utils.Ptr(true),
+				})
+			}),
+		},
+		{
+			description: "system routes disabled",
+			model: fixtureInputModel(func(model *inputModel) {
+				model.RoutingTableId = testRoutingTableId
+				model.NonSystemRoutes = true
+			}),
+			expectedRequest: fixtureRequest(func(request *iaas.ApiUpdateRoutingTableOfAreaRequest) {
+				*request = (*request).UpdateRoutingTableOfAreaPayload(iaas.UpdateRoutingTableOfAreaPayload{
+					Labels:        utils.ConvertStringMapToInterfaceMap(testLabels),
+					Name:          utils.Ptr(testRoutingTableName),
+					Description:   utils.Ptr(testRoutingTableDescription),
+					SystemRoutes:  utils.Ptr(false),
+					DynamicRoutes: utils.Ptr(true),
 				})
 			}),
 		},