@@ -171,22 +171,18 @@ func TestParseInput(t *testing.T) {
171171 description : "direction missing" ,
172172 flagValues : fixtureFlagValues (func (flagValues map [string ]string ) {
173173 delete (flagValues , directionFlag )
174+ delete (flagValues , protocolNumberFlag )
175+ delete (flagValues , protocolNameFlag )
174176 }),
175177 isValid : false ,
176178 },
177179 {
178- description : "protocol is icmp and parameters are missing " ,
180+ description : "protocol is icmp and port range values are provided " ,
179181 flagValues : fixtureFlagValues (func (flagValues map [string ]string ) {
180- delete (flagValues , icmpParameterCodeFlag )
181- delete (flagValues , icmpParameterTypeFlag )
182+ delete (flagValues , protocolNumberFlag )
182183 }),
183184 isValid : false ,
184185 },
185- {
186- description : "protocol is icmp and port range values are provided" ,
187- flagValues : fixtureFlagValues (),
188- isValid : false ,
189- },
190186 {
191187 description : "protocol is not icmp and port range values are provided" ,
192188 flagValues : fixtureFlagValues (func (flagValues map [string ]string ) {
@@ -207,6 +203,7 @@ func TestParseInput(t *testing.T) {
207203 description : "protocol is not icmp and icmp parameters are provided" ,
208204 flagValues : fixtureFlagValues (func (flagValues map [string ]string ) {
209205 flagValues [protocolNameFlag ] = "not-icmp"
206+ delete (flagValues , protocolNumberFlag )
210207 }),
211208 isValid : false ,
212209 },
0 commit comments