replace routed flag with non-routed to align with api values

Author: GokceGK

docs/stackit_beta_network_create.md

@@ -16,8 +16,8 @@ stackit beta network create [flags]
   Create a network with name "network-1"
   $ stackit beta network create --name network-1
 
-  Create a routed network with name "network-1"
-  $ stackit beta network create --name network-1 --routed
+  Create a non-routed network with name "network-1"
+  $ stackit beta network create --name network-1 --non-routed
 
   Create a network with name "network-1" and no gateway
   $ stackit beta network create --name network-1 --no-ipv4-gateway
@@ -44,7 +44,7 @@ stackit beta network create [flags]
   -n, --name string                     Network name
       --no-ipv4-gateway                 If set to true, the network doesn't have an IPv4 gateway
       --no-ipv6-gateway                 If set to true, the network doesn't have an IPv6 gateway
-      --routed                          If set to true, the network is routed and therefore accessible from other networks
+      --non-routed                      If set to true, the network is not routed and therefore not accessible from other networks
 ```
 
 ### Options inherited from parent commands

internal/cmd/beta/network/create/create.go

@@ -31,7 +31,7 @@ const (
 	ipv6PrefixLengthFlag   = "ipv6-prefix-length"
 	ipv6PrefixFlag         = "ipv6-prefix"
 	ipv6GatewayFlag        = "ipv6-gateway"
-	routedFlag             = "routed"
+	nonRoutedFlag          = "non-routed"
 	noIpv4GatewayFlag      = "no-ipv4-gateway"
 	noIpv6GatewayFlag      = "no-ipv6-gateway"
 )
@@ -47,7 +47,7 @@ type inputModel struct {
 	IPv6PrefixLength   *int64
 	IPv6Prefix         *string
 	IPv6Gateway        *string
-	Routed             bool
+	NonRouted          bool
 	NoIPv4Gateway      bool
 	NoIPv6Gateway      bool
 }
@@ -64,8 +64,8 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				`$ stackit beta network create --name network-1`,
 			),
 			examples.NewExample(
-				`Create a routed network with name "network-1"`,
-				`$ stackit beta network create --name network-1 --routed`,
+				`Create a non-routed network with name "network-1"`,
+				`$ stackit beta network create --name network-1 --non-routed`,
 			),
 			examples.NewExample(
 				`Create a network with name "network-1" and no gateway`,
@@ -143,12 +143,10 @@ func configureFlags(cmd *cobra.Command) {
 	cmd.Flags().Int64(ipv6PrefixLengthFlag, 0, "The prefix length of the IPv6 network")
 	cmd.Flags().String(ipv6PrefixFlag, "", "The IPv6 prefix of the network (CIDR)")
 	cmd.Flags().String(ipv6GatewayFlag, "", "The IPv6 gateway of a network. If not specified, the first IP of the network will be assigned as the gateway")
-	cmd.Flags().Bool(routedFlag, false, "If set to true, the network is routed and therefore accessible from other networks")
+	cmd.Flags().Bool(nonRoutedFlag, false, "If set to true, the network is not routed and therefore not accessible from other networks")
 	cmd.Flags().Bool(noIpv4GatewayFlag, false, "If set to true, the network doesn't have an IPv4 gateway")
 	cmd.Flags().Bool(noIpv6GatewayFlag, false, "If set to true, the network doesn't have an IPv6 gateway")
 
-	cmd.MarkFlagsMutuallyExclusive(routedFlag, ipv4DnsNameServersFlag)
-	cmd.MarkFlagsMutuallyExclusive(routedFlag, ipv6DnsNameServersFlag)
 	err := flags.MarkFlagsRequired(cmd, nameFlag)
 	cobra.CheckErr(err)
 }
@@ -170,7 +168,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
 		IPv6PrefixLength:   flags.FlagToInt64Pointer(p, cmd, ipv6PrefixLengthFlag),
 		IPv6Prefix:         flags.FlagToStringPointer(p, cmd, ipv6PrefixFlag),
 		IPv6Gateway:        flags.FlagToStringPointer(p, cmd, ipv6GatewayFlag),
-		Routed:             flags.FlagToBoolValue(p, cmd, routedFlag),
+		NonRouted:          flags.FlagToBoolValue(p, cmd, nonRoutedFlag),
 		NoIPv4Gateway:      flags.FlagToBoolValue(p, cmd, noIpv4GatewayFlag),
 		NoIPv6Gateway:      flags.FlagToBoolValue(p, cmd, noIpv6GatewayFlag),
 	}
@@ -219,9 +217,14 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
 		}
 	}
 
+	routed := true
+	if model.NonRouted {
+		routed = false
+	}
+
 	payload := iaas.CreateNetworkPayload{
 		Name:   model.Name,
-		Routed: &model.Routed,
+		Routed: &routed,
 	}
 
 	if addressFamily.Ipv4 != nil || addressFamily.Ipv6 != nil {

internal/cmd/beta/network/create/create_test.go

@@ -35,7 +35,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]st
 		ipv6PrefixLengthFlag:   "24",
 		ipv6PrefixFlag:         "2001:4860:4860::8888",
 		ipv6GatewayFlag:        "2001:4860:4860::8888",
-		routedFlag:             "true",
+		nonRoutedFlag:          "false",
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -58,7 +58,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 		IPv6PrefixLength:   utils.Ptr(int64(24)),
 		IPv6Prefix:         utils.Ptr("2001:4860:4860::8888"),
 		IPv6Gateway:        utils.Ptr("2001:4860:4860::8888"),
-		Routed:             true,
+		NonRouted:          false,
 	}
 	for _, mod := range mods {
 		mod(model)
@@ -79,7 +79,7 @@ func fixtureRequiredRequest(mods ...func(request *iaas.ApiCreateNetworkRequest))
 	request := testClient.CreateNetwork(testCtx, testProjectId)
 	request = request.CreateNetworkPayload(iaas.CreateNetworkPayload{
 		Name:   utils.Ptr("example-network-name"),
-		Routed: utils.Ptr(false),
+		Routed: utils.Ptr(true),
 	})
 	for _, mod := range mods {
 		mod(&request)
@@ -229,11 +229,11 @@ func TestParseInput(t *testing.T) {
 		{
 			description: "use routed true",
 			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues[routedFlag] = "true"
+				flagValues[nonRoutedFlag] = "false"
 			}),
 			isValid: true,
 			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.Routed = true
+				model.NonRouted = false
 			}),
 		},
 	}