Skip to content

Commit dd6e08b

Browse files
hcsa73Henrique Santos
andauthored
Replace membership with authorization (#65)
* Replace membership with authorization * Reorder fields --------- Co-authored-by: Henrique Santos <[email protected]>
1 parent 9de168a commit dd6e08b

File tree

25 files changed

+106
-106
lines changed

25 files changed

+106
-106
lines changed

docs/stackit_config_set.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ stackit config set [flags]
2929
### Options
3030

3131
```
32+
--authorization-custom-endpoint string Authorization custom endpoint
3233
--dns-custom-endpoint string DNS custom endpoint
3334
-h, --help Help for "stackit config set"
3435
--logme-custom-endpoint string LogMe custom endpoint
3536
--mariadb-custom-endpoint string MariaDB custom endpoint
36-
--membership-custom-endpoint string Membership custom endpoint
3737
--mongodbflex-custom-endpoint string MongoDB Flex custom endpoint
3838
--opensearch-custom-endpoint string OpenSearch custom endpoint
3939
--postgresflex-custom-endpoint string PostgreSQL Flex custom endpoint

docs/stackit_config_unset.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ stackit config unset [flags]
2727

2828
```
2929
--async Configuration option to run commands asynchronously
30+
--authorization-custom-endpoint Authorization custom endpoint
3031
--dns-custom-endpoint DNS custom endpoint
3132
-h, --help Help for "stackit config unset"
3233
--logme-custom-endpoint LogMe custom endpoint
3334
--mariadb-custom-endpoint MariaDB custom endpoint
34-
--membership-custom-endpoint Membership custom endpoint
3535
--mongodbflex-custom-endpoint MongoDB Flex custom endpoint
3636
--opensearch-custom-endpoint OpenSearch custom endpoint
3737
--output-format Output format

docs/stackit_mongodbflex_instance_create.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ stackit mongodbflex instance create [flags]
3535
--ram int Amount of RAM (in GB)
3636
--storage-class string Storage class (default "premium-perf2-mongodb")
3737
--storage-size int Storage size (in GB) (default 10)
38-
--type string Instance type, one of ["Replica" "Sharded" "Single"] (default "Replica")
38+
--type string Instance type, one of ["Single" "Replica" "Sharded"] (default "Replica")
3939
--version string MongoDB version. Defaults to the latest version available
4040
```
4141

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ require (
1111
github.com/spf13/pflag v1.0.5
1212
github.com/spf13/viper v1.18.2
1313
github.com/stackitcloud/stackit-sdk-go/core v0.7.7
14+
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.1.0
1415
github.com/stackitcloud/stackit-sdk-go/services/dns v0.8.2
15-
github.com/stackitcloud/stackit-sdk-go/services/membership v0.3.4
1616
github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v0.10.3
1717
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.9.2
1818
github.com/stackitcloud/stackit-sdk-go/services/postgresflex v0.9.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,14 @@ github.com/spf13/viper v1.18.2 h1:LUXCnvUvSM6FXAsj6nnfc8Q2tp1dIgUfY9Kc8GsSOiQ=
7979
github.com/spf13/viper v1.18.2/go.mod h1:EKmWIqdnk5lOcmR72yw6hS+8OPYcwD0jteitLMVB+yk=
8080
github.com/stackitcloud/stackit-sdk-go/core v0.7.7 h1:w1T8I2ERT5xPHXS+UV9maSseK8tyUJQjzS21hhRSWjU=
8181
github.com/stackitcloud/stackit-sdk-go/core v0.7.7/go.mod h1:nfC2Tbjd73Ivn8wEp3lvG/dmiXHgl6QX+HY2Ih3aGgw=
82+
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.1.0 h1:FkOaz7ZutvteismzVHsabddg5GLWvRCA9jEzWH1/V9Y=
83+
github.com/stackitcloud/stackit-sdk-go/services/authorization v0.1.0/go.mod h1:n2iI0NZdawwkGt3nqm09l8kSJ3MGgLCCOWdVzanEPzA=
8284
github.com/stackitcloud/stackit-sdk-go/services/dns v0.8.2 h1:Wj3A+BAitSK74dRMxEGoKU1itEZmjwrAECT/CgsEJOQ=
8385
github.com/stackitcloud/stackit-sdk-go/services/dns v0.8.2/go.mod h1:RYRnST/3Kz5GmxMmFvsaYFblfZ/LMxw8r9DNfnRhX/4=
8486
github.com/stackitcloud/stackit-sdk-go/services/logme v0.10.0 h1:5+X0sKPdnLT/a1Jt73YphecQpPEOpd6TY6XdK0zGqP4=
8587
github.com/stackitcloud/stackit-sdk-go/services/logme v0.10.0/go.mod h1:e/I/8wJEqLdzdEgsGh7UbwbMMMNL5F1os25K+vQSzOc=
8688
github.com/stackitcloud/stackit-sdk-go/services/mariadb v0.10.0 h1:WxvySRZfkecOVjrpK3NiyqPL9YWKSpdBbIf55Y5HlNs=
8789
github.com/stackitcloud/stackit-sdk-go/services/mariadb v0.10.0/go.mod h1:GQ+UyuUOANO/kQOIhqLmMYRH34NbZShMrfmUY6hTSjo=
88-
github.com/stackitcloud/stackit-sdk-go/services/membership v0.3.4 h1:0OT/UBP55/GPMm9Tks9Uhb+PvP/2zI6ZUySfh7px+kY=
89-
github.com/stackitcloud/stackit-sdk-go/services/membership v0.3.4/go.mod h1:6ovfcQJ96ivkBpSI933lVl2a/SWprpVGoK6YNKycLps=
9090
github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v0.10.3 h1:M7ALIg1tE8MFLLw9Um0iyvdBgIhl83tJ0sWRjP7YqMM=
9191
github.com/stackitcloud/stackit-sdk-go/services/mongodbflex v0.10.3/go.mod h1:LWfUBjGQWF3SZivQdUdAC/WxJkx8ImJKy5GFMV3tXHY=
9292
github.com/stackitcloud/stackit-sdk-go/services/opensearch v0.9.2 h1:dwZ1NDD+AxTaZqAeR/0PY7yt32dbABhQH1Vsnt8A+hg=

internal/cmd/config/set/set.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ import (
1818
const (
1919
sessionTimeLimitFlag = "session-time-limit"
2020

21+
authorizationCustomEndpointFlag = "authorization-custom-endpoint"
2122
dnsCustomEndpointFlag = "dns-custom-endpoint"
2223
logMeCustomEndpointFlag = "logme-custom-endpoint"
2324
mariaDBCustomEndpointFlag = "mariadb-custom-endpoint"
24-
membershipCustomEndpointFlag = "membership-custom-endpoint"
2525
mongoDBFlexCustomEndpointFlag = "mongodbflex-custom-endpoint"
2626
openSearchCustomEndpointFlag = "opensearch-custom-endpoint"
2727
postgresFlexCustomEndpointFlag = "postgresflex-custom-endpoint"
@@ -90,10 +90,10 @@ func NewCmd() *cobra.Command {
9090
func configureFlags(cmd *cobra.Command) {
9191
cmd.Flags().String(sessionTimeLimitFlag, "", "Maximum time before authentication is required again. Can't be larger than 24h. Examples: 3h, 5h30m40s (BETA: currently values greater than 2h have no effect)")
9292

93+
cmd.Flags().String(authorizationCustomEndpointFlag, "", "Authorization custom endpoint")
9394
cmd.Flags().String(dnsCustomEndpointFlag, "", "DNS custom endpoint")
9495
cmd.Flags().String(logMeCustomEndpointFlag, "", "LogMe custom endpoint")
9596
cmd.Flags().String(mariaDBCustomEndpointFlag, "", "MariaDB custom endpoint")
96-
cmd.Flags().String(membershipCustomEndpointFlag, "", "Membership custom endpoint")
9797
cmd.Flags().String(mongoDBFlexCustomEndpointFlag, "", "MongoDB Flex custom endpoint")
9898
cmd.Flags().String(openSearchCustomEndpointFlag, "", "OpenSearch custom endpoint")
9999
cmd.Flags().String(postgresFlexCustomEndpointFlag, "", "PostgreSQL Flex custom endpoint")
@@ -103,14 +103,14 @@ func configureFlags(cmd *cobra.Command) {
103103
cmd.Flags().String(serviceAccountCustomEndpointFlag, "", "Service Account custom endpoint")
104104
cmd.Flags().String(skeCustomEndpointFlag, "", "SKE custom endpoint")
105105

106-
err := viper.BindPFlag(config.DNSCustomEndpointKey, cmd.Flags().Lookup(dnsCustomEndpointFlag))
106+
err := viper.BindPFlag(config.AuthorizationCustomEndpointKey, cmd.Flags().Lookup(authorizationCustomEndpointFlag))
107+
cobra.CheckErr(err)
108+
err = viper.BindPFlag(config.DNSCustomEndpointKey, cmd.Flags().Lookup(dnsCustomEndpointFlag))
107109
cobra.CheckErr(err)
108110
err = viper.BindPFlag(config.LogMeCustomEndpointKey, cmd.Flags().Lookup(logMeCustomEndpointFlag))
109111
cobra.CheckErr(err)
110112
err = viper.BindPFlag(config.MariaDBCustomEndpointKey, cmd.Flags().Lookup(mariaDBCustomEndpointFlag))
111113
cobra.CheckErr(err)
112-
err = viper.BindPFlag(config.MembershipCustomEndpointKey, cmd.Flags().Lookup(membershipCustomEndpointFlag))
113-
cobra.CheckErr(err)
114114
err = viper.BindPFlag(config.MongoDBFlexCustomEndpointKey, cmd.Flags().Lookup(mongoDBFlexCustomEndpointFlag))
115115
cobra.CheckErr(err)
116116
err = viper.BindPFlag(config.OpenSearchCustomEndpointKey, cmd.Flags().Lookup(openSearchCustomEndpointFlag))

internal/cmd/config/unset/unset.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ const (
1818
outputFormatFlag = globalflags.OutputFormatFlag
1919
projectIdFlag = globalflags.ProjectIdFlag
2020

21+
authorizationCustomEndpointFlag = "authorization-custom-endpoint"
2122
dnsCustomEndpointFlag = "dns-custom-endpoint"
2223
logMeCustomEndpointFlag = "logme-custom-endpoint"
2324
mariaDBCustomEndpointFlag = "mariadb-custom-endpoint"
24-
membershipCustomEndpointFlag = "membership-custom-endpoint"
2525
mongoDBFlexCustomEndpointFlag = "mongodbflex-custom-endpoint"
2626
openSearchCustomEndpointFlag = "opensearch-custom-endpoint"
2727
postgresFlexCustomEndpointFlag = "postgresflex-custom-endpoint"
@@ -37,10 +37,10 @@ type inputModel struct {
3737
OutputFormat bool
3838
ProjectId bool
3939

40+
AuthorizationCustomEndpoint bool
4041
DNSCustomEndpoint bool
4142
LogMeCustomEndpoint bool
4243
MariaDBCustomEndpoint bool
43-
MembershipCustomEndpoint bool
4444
MongoDBFlexCustomEndpoint bool
4545
OpenSearchCustomEndpoint bool
4646
PostgresFlexCustomEndpoint bool
@@ -81,6 +81,9 @@ func NewCmd() *cobra.Command {
8181
viper.Set(config.ProjectIdKey, "")
8282
}
8383

84+
if model.AuthorizationCustomEndpoint {
85+
viper.Set(config.AuthorizationCustomEndpointKey, "")
86+
}
8487
if model.DNSCustomEndpoint {
8588
viper.Set(config.DNSCustomEndpointKey, "")
8689
}
@@ -90,9 +93,6 @@ func NewCmd() *cobra.Command {
9093
if model.MariaDBCustomEndpoint {
9194
viper.Set(config.MariaDBCustomEndpointKey, "")
9295
}
93-
if model.MembershipCustomEndpoint {
94-
viper.Set(config.MembershipCustomEndpointKey, "")
95-
}
9696
if model.MongoDBFlexCustomEndpoint {
9797
viper.Set(config.MongoDBFlexCustomEndpointKey, "")
9898
}
@@ -134,10 +134,10 @@ func configureFlags(cmd *cobra.Command) {
134134
cmd.Flags().Bool(projectIdFlag, false, "Project ID")
135135
cmd.Flags().Bool(outputFormatFlag, false, "Output format")
136136

137+
cmd.Flags().Bool(authorizationCustomEndpointFlag, false, "Authorization custom endpoint")
137138
cmd.Flags().Bool(dnsCustomEndpointFlag, false, "DNS custom endpoint")
138139
cmd.Flags().Bool(logMeCustomEndpointFlag, false, "LogMe custom endpoint")
139140
cmd.Flags().Bool(mariaDBCustomEndpointFlag, false, "MariaDB custom endpoint")
140-
cmd.Flags().Bool(membershipCustomEndpointFlag, false, "Membership custom endpoint")
141141
cmd.Flags().Bool(mongoDBFlexCustomEndpointFlag, false, "MongoDB Flex custom endpoint")
142142
cmd.Flags().Bool(openSearchCustomEndpointFlag, false, "OpenSearch custom endpoint")
143143
cmd.Flags().Bool(postgresFlexCustomEndpointFlag, false, "PostgreSQL Flex custom endpoint")
@@ -154,10 +154,10 @@ func parseInput(cmd *cobra.Command) *inputModel {
154154
OutputFormat: flags.FlagToBoolValue(cmd, outputFormatFlag),
155155
ProjectId: flags.FlagToBoolValue(cmd, projectIdFlag),
156156

157+
AuthorizationCustomEndpoint: flags.FlagToBoolValue(cmd, authorizationCustomEndpointFlag),
157158
DNSCustomEndpoint: flags.FlagToBoolValue(cmd, dnsCustomEndpointFlag),
158159
LogMeCustomEndpoint: flags.FlagToBoolValue(cmd, logMeCustomEndpointFlag),
159160
MariaDBCustomEndpoint: flags.FlagToBoolValue(cmd, mariaDBCustomEndpointFlag),
160-
MembershipCustomEndpoint: flags.FlagToBoolValue(cmd, membershipCustomEndpointFlag),
161161
MongoDBFlexCustomEndpoint: flags.FlagToBoolValue(cmd, mongoDBFlexCustomEndpointFlag),
162162
OpenSearchCustomEndpoint: flags.FlagToBoolValue(cmd, openSearchCustomEndpointFlag),
163163
PostgresFlexCustomEndpoint: flags.FlagToBoolValue(cmd, postgresFlexCustomEndpointFlag),

internal/cmd/organization/member/add/add.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import (
99
"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
1010
"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
1111
"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
12-
"github.com/stackitcloud/stackit-cli/internal/pkg/services/membership/client"
12+
"github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client"
1313
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
1414

1515
"github.com/spf13/cobra"
16-
"github.com/stackitcloud/stackit-sdk-go/services/membership"
16+
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
1717
)
1818

1919
const (
@@ -107,10 +107,10 @@ func parseInput(cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
107107
}, nil
108108
}
109109

110-
func buildRequest(ctx context.Context, model *inputModel, apiClient *membership.APIClient) membership.ApiAddMembersRequest {
110+
func buildRequest(ctx context.Context, model *inputModel, apiClient *authorization.APIClient) authorization.ApiAddMembersRequest {
111111
req := apiClient.AddMembers(ctx, *model.OrganizationId)
112-
req = req.AddMembersPayload(membership.AddMembersPayload{
113-
Members: utils.Ptr([]membership.Member{
112+
req = req.AddMembersPayload(authorization.AddMembersPayload{
113+
Members: utils.Ptr([]authorization.Member{
114114
{
115115
Subject: utils.Ptr(model.Subject),
116116
Role: model.Role,

internal/cmd/organization/member/add/add_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ import (
99

1010
"github.com/google/go-cmp/cmp"
1111
"github.com/google/go-cmp/cmp/cmpopts"
12-
"github.com/stackitcloud/stackit-sdk-go/services/membership"
12+
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
1313
)
1414

1515
type testCtxKey struct{}
1616

1717
var testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
18-
var testClient = &membership.APIClient{}
18+
var testClient = &authorization.APIClient{}
1919
var testOrganizationID = "some-organization-id"
2020
var testSubject = "[email protected]"
2121
var testRole = "reader"
@@ -54,10 +54,10 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
5454
return model
5555
}
5656

57-
func fixtureRequest(mods ...func(request *membership.ApiAddMembersRequest)) membership.ApiAddMembersRequest {
57+
func fixtureRequest(mods ...func(request *authorization.ApiAddMembersRequest)) authorization.ApiAddMembersRequest {
5858
request := testClient.AddMembers(testCtx, testOrganizationID)
59-
request = request.AddMembersPayload(membership.AddMembersPayload{
60-
Members: utils.Ptr([]membership.Member{
59+
request = request.AddMembersPayload(authorization.AddMembersPayload{
60+
Members: utils.Ptr([]authorization.Member{
6161
{
6262
Subject: &testSubject,
6363
Role: &testRole,
@@ -178,7 +178,7 @@ func TestBuildRequest(t *testing.T) {
178178
tests := []struct {
179179
description string
180180
model *inputModel
181-
expectedRequest membership.ApiAddMembersRequest
181+
expectedRequest authorization.ApiAddMembersRequest
182182
}{
183183
{
184184
description: "base",

internal/cmd/organization/member/list/list.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ import (
1111
"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
1212
"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
1313
"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
14-
"github.com/stackitcloud/stackit-cli/internal/pkg/services/membership/client"
14+
"github.com/stackitcloud/stackit-cli/internal/pkg/services/authorization/client"
1515
"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
1616

1717
"github.com/spf13/cobra"
18-
"github.com/stackitcloud/stackit-sdk-go/services/membership"
18+
"github.com/stackitcloud/stackit-sdk-go/services/authorization"
1919
)
2020

2121
const (
@@ -122,15 +122,15 @@ func parseInput(cmd *cobra.Command) (*inputModel, error) {
122122
}, nil
123123
}
124124

125-
func buildRequest(ctx context.Context, model *inputModel, apiClient *membership.APIClient) membership.ApiListMembersRequest {
125+
func buildRequest(ctx context.Context, model *inputModel, apiClient *authorization.APIClient) authorization.ApiListMembersRequest {
126126
req := apiClient.ListMembers(ctx, organizationResourceType, *model.OrganizationId)
127127
if model.Subject != nil {
128128
req = req.Subject(*model.Subject)
129129
}
130130
return req
131131
}
132132

133-
func outputResult(cmd *cobra.Command, model *inputModel, members []membership.Member) error {
133+
func outputResult(cmd *cobra.Command, model *inputModel, members []authorization.Member) error {
134134
sortFn := func(i, j int) bool {
135135
switch model.SortBy {
136136
case "subject":

0 commit comments

Comments
 (0)