Address review: add waiters to create/update/delete operations

Author: Yago Carlos Fernandez Gou

internal/cmd/beta/intake/runner/create/create.go

@@ -9,6 +9,7 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/intake"
 
+	"github.com/stackitcloud/stackit-cli/internal/cmd/beta/intake/wait"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	cliErr "github.com/stackitcloud/stackit-cli/internal/pkg/errors"
@@ -18,6 +19,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/intake/client"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/spinner"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 )
 
@@ -87,6 +89,17 @@ func NewCreateCmd(p *params.CmdParams) *cobra.Command {
 				return fmt.Errorf("create Intake Runner: %w", err)
 			}
 
+			// Wait for async operation, if async mode not enabled
+			if !model.Async {
+				s := spinner.New(p.Printer)
+				s.Start("Creating STACKIT Intake Runner instance")
+				_, err = wait.CreateOrUpdateIntakeRunnerWaitHandler(ctx, apiClient, model.ProjectId, model.Region, resp.GetId()).WaitWithContext(ctx)
+				if err != nil {
+					return fmt.Errorf("wait for STACKIT Instance creation: %w", err)
+				}
+				s.Stop()
+			}
+
 			return outputResult(p.Printer, model.OutputFormat, projectLabel, resp)
 		},
 	}

internal/cmd/beta/intake/runner/delete/delete.go

@@ -5,13 +5,15 @@ import (
 	"fmt"
 
 	"github.com/spf13/cobra"
+	"github.com/stackitcloud/stackit-cli/internal/cmd/beta/intake/wait"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	cliErr "github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/intake/client"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/spinner"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/intake"
 )
@@ -64,7 +66,23 @@ func NewDeleteCmd(p *params.CmdParams) *cobra.Command {
 			if err = req.Execute(); err != nil {
 				return fmt.Errorf("delete Intake Runner: %w", err)
 			}
-			p.Printer.Info("Deleted runner %s\n", model.RunnerId)
+
+			// Wait for async operation, if async mode not enabled
+			if !model.Async {
+				s := spinner.New(p.Printer)
+				s.Start("Deleting STACKIT Intake Runner instance")
+				_, err = wait.DeleteIntakeRunnerWaitHandler(ctx, apiClient, model.ProjectId, model.Region, model.RunnerId).WaitWithContext(ctx)
+				if err != nil {
+					return fmt.Errorf("wait for STACKIT Instance deletion: %w", err)
+				}
+				s.Stop()
+			}
+
+			operationState := "Deleted"
+			if model.Async {
+				operationState = "Triggered deletion of"
+			}
+			p.Printer.Info("%s stackit Intake Runner instance %s \n", operationState, model.RunnerId)
 
 			return nil
 		},

internal/cmd/beta/intake/runner/update/update.go

@@ -8,6 +8,7 @@ import (
 	"github.com/goccy/go-yaml"
 	"github.com/spf13/cobra"
 
+	"github.com/stackitcloud/stackit-cli/internal/cmd/beta/intake/wait"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/params"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	cliErr "github.com/stackitcloud/stackit-cli/internal/pkg/errors"
@@ -17,6 +18,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/intake/client"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/spinner"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
 	"github.com/stackitcloud/stackit-sdk-go/services/intake"
 )
@@ -83,6 +85,17 @@ func NewUpdateCmd(p *params.CmdParams) *cobra.Command {
 				return fmt.Errorf("update Intake Runner: %w", err)
 			}
 
+			// Wait for async operation, if async mode not enabled
+			if !model.Async {
+				s := spinner.New(p.Printer)
+				s.Start("Updating STACKIT Intake Runner instance")
+				_, err = wait.CreateOrUpdateIntakeRunnerWaitHandler(ctx, apiClient, model.ProjectId, model.Region, model.RunnerId).WaitWithContext(ctx)
+				if err != nil {
+					return fmt.Errorf("wait for STACKIT Instance creation: %w", err)
+				}
+				s.Stop()
+			}
+
 			return outputResult(p.Printer, model.OutputFormat, projectLabel, resp)
 		},
 	}