fix panic in auth.TokenExpired #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a panic, if CLI is authenticated with an invalid Service Account Token.
stackit auth activate-service-accountaccept any JWT token with an email claim.However,
stackit auth get-access-tokenpanics, because the command checks for an expire date, which is not present.The underlaying JWT library does not return an error, if the exp claim is not present.
JWT RFC explained that exp is an manatory field. However in any case, an application should never panic.
Ref: https://github.com/golang-jwt/jwt/blob/048854f1b0ac96c0a843d52fc09d7878b853683f/map_claims.go#L48
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)