Skip to content

Commit ba708bd

Browse files
committed
adjust sdk-pr and scripts worfklow for java
1 parent 31a0b27 commit ba708bd

File tree

5 files changed

+8
-35
lines changed

5 files changed

+8
-35
lines changed

.github/actions/build/java/action.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

.github/actions/generate-sdk/java/action.yaml

Lines changed: 0 additions & 11 deletions
This file was deleted.

.github/workflows/sdk-pr.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ jobs:
9898
java-version: ${{ env.JAVA_VERSION }}
9999
- name: Checkout
100100
uses: actions/checkout@v4
101-
- name: Build
102-
uses: ./.github/actions/build/java
101+
- name: Download OAS
102+
run: make download-oas
103103
- name: Generate SDK
104-
uses: ./.github/actions/generate-sdk/java
104+
run: make generate-sdk LANGUAGE=java
105105
- name: Push SDK
106106
env:
107107
GH_REPO: "stackitcloud/stackit-sdk-java"

scripts/project.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ elif [ "$action" = "tools" ]; then
2727
elif [ "${LANGUAGE}" == "python" ]; then
2828
pip install black==24.8.0 isort~=5.13.2 autoimport~=1.6.1
2929
elif [ "${LANGUAGE}" == "java" ]; then
30-
# Java tools are typically installed via the system or actions/setup-java
31-
# Additional Java-specific tools can be added here if needed
3230
echo "Java tools are ready for use"
3331
else
3432
echo "! Invalid language: $($LANGUAGE), please use $0 help for help"

scripts/sdk-create-pr.sh

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,13 @@ for service_path in ${work_dir}/sdk_to_push/services/*; do
101101
fi
102102

103103
# If lint or test fails for a service, we skip it and continue to the next one
104-
# Skip linting for Java as it doesn't have a lint target
105-
if [ "${LANGUAGE}" != "java" ]; then
106-
make lint skip-non-generated-files=true service=$service || {
107-
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
108-
continue
109-
}
110-
else
111-
echo ">> Skipping linting for Java service $service (no lint target available)"
112-
fi
104+
make lint skip-non-generated-files=true service=$service || {
105+
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
106+
continue
107+
}
113108
# Our unit test template fails because it doesn't support fields with validations,
114109
# such as the UUID component used by IaaS. We introduce this hardcoded skip until we fix it
115-
# We also skip tests for Java as it doesn't have a test target available yet
116-
if [ "${LANGUAGE}" = "java" ] || [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
110+
if [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
117111
echo ">> Skipping tests of $service service"
118112
else
119113
make test skip-non-generated-files=true service=$service || {

0 commit comments

Comments
 (0)