Skip to content

Commit dadc7bd

Browse files
committed
workaround to skip lint and test for now
1 parent 294c3af commit dadc7bd

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

scripts/sdk-create-pr.sh

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,19 @@ for service_path in ${work_dir}/sdk_to_push/services/*; do
101101
fi
102102

103103
# If lint or test fails for a service, we skip it and continue to the next one
104-
make lint skip-non-generated-files=true service=$service || {
105-
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
106-
continue
107-
}
104+
# Skip linting for Java as it doesn't have a lint target
105+
if [ "${LANGUAGE}" != "java" ]; then
106+
make lint skip-non-generated-files=true service=$service || {
107+
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
108+
continue
109+
}
110+
else
111+
echo ">> Skipping linting for Java service $service (no lint target available)"
112+
fi
108113
# Our unit test template fails because it doesn't support fields with validations,
109114
# such as the UUID component used by IaaS. We introduce this hardcoded skip until we fix it
110-
if [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
115+
# We also skip tests for Java as it doesn't have a test target available yet
116+
if [ "${LANGUAGE}" = "java" ] || [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
111117
echo ">> Skipping tests of $service service"
112118
else
113119
make test skip-non-generated-files=true service=$service || {

0 commit comments

Comments
 (0)