Skip to content

Commit 2753631

Browse files
committed
rename convertion function to be more generic
1 parent 54110ff commit 2753631

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

core/utils/utils.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ func Contains[T comparable](slice []T, element T) bool {
1919
return false
2020
}
2121

22-
// ConvertForYAML converts a struct to a map with byte arrays converted to base64 strings
23-
// for proper YAML marshaling. This handles the case where []byte fields need to be
24-
// displayed as base64 strings in YAML output instead of byte arrays.
25-
func ConvertForYAML(obj interface{}) (map[string]interface{}, error) {
22+
// ConvertByteArraysToBase64 converts a struct to a map with byte arrays converted to base64 strings.
23+
// This is useful for serialization formats like YAML where []byte fields should be displayed
24+
// as base64 strings instead of byte arrays. Works with any struct containing []byte fields.
25+
func ConvertByteArraysToBase64(obj interface{}) (map[string]interface{}, error) {
2626
if obj == nil {
2727
return nil, nil
2828
}

core/utils/utils_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ type TestServer struct {
4646
Data []byte `json:"data,omitempty"`
4747
}
4848

49-
func TestConvertForYAML(t *testing.T) {
49+
func TestConvertByteArraysToBase64(t *testing.T) {
5050
// Test with nil input
51-
result, err := ConvertForYAML(nil)
51+
result, err := ConvertByteArraysToBase64(nil)
5252
if err != nil {
5353
t.Fatalf("Expected no error for nil input, got: %v", err)
5454
}
@@ -66,7 +66,7 @@ func TestConvertForYAML(t *testing.T) {
6666
Data: data,
6767
}
6868

69-
result1, err := ConvertForYAML(server)
69+
result1, err := ConvertByteArraysToBase64(server)
7070
if err != nil {
7171
t.Fatalf("Expected no error, got: %v", err)
7272
}
@@ -97,15 +97,15 @@ func TestConvertForYAML(t *testing.T) {
9797
}
9898
}
9999

100-
func TestConvertForYAMLWithNilPointer(t *testing.T) {
100+
func TestConvertByteArraysToBase64WithNilPointer(t *testing.T) {
101101
// Test with nil pointer to byte array
102102
server := TestServer{
103103
Name: "test-server",
104104
UserData: nil, // nil pointer
105105
Data: []byte("test"),
106106
}
107107

108-
result2, err := ConvertForYAML(server)
108+
result2, err := ConvertByteArraysToBase64(server)
109109
if err != nil {
110110
t.Fatalf("Expected no error, got: %v", err)
111111
}
@@ -126,7 +126,7 @@ func TestConvertForYAMLWithNilPointer(t *testing.T) {
126126
}
127127
}
128128

129-
func TestConvertForYAMLWithEmptyByteArray(t *testing.T) {
129+
func TestConvertByteArraysToBase64WithEmptyByteArray(t *testing.T) {
130130
// Test with empty byte array
131131
emptyData := []byte{}
132132

@@ -135,7 +135,7 @@ func TestConvertForYAMLWithEmptyByteArray(t *testing.T) {
135135
Data: emptyData,
136136
}
137137

138-
result3, err := ConvertForYAML(server)
138+
result3, err := ConvertByteArraysToBase64(server)
139139
if err != nil {
140140
t.Fatalf("Expected no error, got: %v", err)
141141
}

0 commit comments

Comments
 (0)