Request waiter implementation

Author: vicentepinto98

services/iaasalpha/wait/wait.go

@@ -17,12 +17,23 @@ const (
 	ErrorStatus           = "ERROR"
 	ServerActiveStatus    = "ACTIVE"
 	ServerResizingStatus  = "RESIZING"
+
+	RequestCreateAction  = "CREATE"
+	RequestUpdateAction  = "UPDATE"
+	RequestDeleteAction  = "DELETE"
+	RequestCreatedStatus = "CREATED"
+	RequestUpdatedStatus = "UPDATED"
+	RequestDeletedStatus = "DELETED"
+	RequestFailedStatus  = "FAILED"
+
+	XRequestIDHeader = "X-Request-Id"
 )
 
 // Interfaces needed for tests
 type APIClientInterface interface {
 	GetVolumeExecute(ctx context.Context, projectId string, volumeId string) (*iaasalpha.Volume, error)
 	GetServerExecute(ctx context.Context, projectId string, serverId string) (*iaasalpha.Server, error)
+	GetProjectRequestExecute(ctx context.Context, projectId string, requestId string) (*iaasalpha.Request, error)
 }
 
 // CreateVolumeWaitHandler will wait for volume creation
@@ -165,3 +176,51 @@ func DeleteServerWaitHandler(ctx context.Context, a APIClientInterface, projectI
 	handler.SetTimeout(20 * time.Minute)
 	return handler
 }
+
+// ProjectRequestWaitHandler will wait for a request to succeed
+// It receives a request id that can be obtained from the x-request-id header in the http response of any operation in the IaaS API
+func ProjectRequestWaitHandler(ctx context.Context, a APIClientInterface, projectId, requestId string) *wait.AsyncActionHandler[iaasalpha.Request] {
+	handler := wait.New(func() (waitFinished bool, response *iaasalpha.Request, err error) {
+		request, err := a.GetProjectRequestExecute(ctx, projectId, requestId)
+		if err != nil {
+			return false, request, err
+		}
+
+		if request == nil {
+			return false, request, fmt.Errorf("request failed for request with id %s: nil response from GetProjectRequestExecute", requestId)
+		}
+
+		if request.RequestId == nil || request.RequestAction == nil || request.Status == nil {
+			return false, request, fmt.Errorf("request failed for request with id %s, the response is not valid: the id, the request action or the status are missing", requestId)
+		}
+
+		if *request.RequestId != requestId {
+			return false, request, fmt.Errorf("request failed for request with id %s: the response id doesn't match the request id", requestId)
+		}
+
+		switch *request.RequestAction {
+		case RequestCreateAction:
+			if *request.Status == RequestCreatedStatus {
+				return true, request, nil
+			}
+		case RequestUpdateAction:
+			if *request.Status == RequestUpdatedStatus {
+				return true, request, nil
+			}
+		case RequestDeleteAction:
+			if *request.Status == RequestDeletedStatus {
+				return true, request, nil
+			}
+		default:
+			return false, request, fmt.Errorf("request failed for request with id %s, the request action %s is not supported", requestId, *request.RequestAction)
+		}
+
+		if *request.Status == RequestFailedStatus {
+			return true, request, fmt.Errorf("request failed for request with id %s", requestId)
+		}
+
+		return false, request, nil
+	})
+	handler.SetTimeout(20 * time.Minute)
+	return handler
+}

services/iaasalpha/wait/wait_test.go

@@ -12,11 +12,13 @@ import (
 )
 
 type apiClientMocked struct {
-	getVolumeFails bool
-	getServerFails bool
-	isDeleted      bool
-	resourceState  string
-	returnResizing bool
+	getVolumeFails         bool
+	getServerFails         bool
+	getProjectRequestFails bool
+	isDeleted              bool
+	resourceState          string
+	requestAction          string
+	returnResizing         bool
 }
 
 func (a *apiClientMocked) GetVolumeExecute(_ context.Context, _, _ string) (*iaasalpha.Volume, error) {
@@ -65,6 +67,20 @@ func (a *apiClientMocked) GetServerExecute(_ context.Context, _, _ string) (*iaa
 	}, nil
 }
 
+func (a *apiClientMocked) GetProjectRequestExecute(_ context.Context, _, _ string) (*iaasalpha.Request, error) {
+	if a.getProjectRequestFails {
+		return nil, &oapierror.GenericOpenAPIError{
+			StatusCode: 500,
+		}
+	}
+
+	return &iaasalpha.Request{
+		RequestId:     utils.Ptr("rid"),
+		RequestAction: &a.requestAction,
+		Status:        &a.resourceState,
+	}, nil
+}
+
 func TestCreateVolumeWaitHandler(t *testing.T) {
 	tests := []struct {
 		desc          string
@@ -396,3 +412,98 @@ func TestResizeServerWaitHandler(t *testing.T) {
 		})
 	}
 }
+
+func TestProjectRequestWaitHandler(t *testing.T) {
+	tests := []struct {
+		desc          string
+		getFails      bool
+		requestState  string
+		requestAction string
+		wantErr       bool
+		wantResp      bool
+	}{
+		{
+			desc:          "create_succeeded",
+			getFails:      false,
+			requestAction: RequestCreateAction,
+			requestState:  RequestCreatedStatus,
+			wantErr:       false,
+			wantResp:      true,
+		},
+		{
+			desc:          "update_succeeded",
+			getFails:      false,
+			requestAction: RequestUpdateAction,
+			requestState:  RequestUpdatedStatus,
+			wantErr:       false,
+			wantResp:      true,
+		},
+		{
+			desc:          "delete_succeeded",
+			getFails:      false,
+			requestAction: RequestDeleteAction,
+			requestState:  RequestDeletedStatus,
+			wantErr:       false,
+			wantResp:      true,
+		},
+		{
+			desc:          "unsupported_action",
+			getFails:      false,
+			requestAction: "OTHER_ACTION",
+			wantErr:       true,
+			wantResp:      true,
+		},
+		{
+			desc:          "error_status",
+			getFails:      false,
+			requestAction: RequestCreateAction,
+			requestState:  ErrorStatus,
+			wantErr:       true,
+			wantResp:      true,
+		},
+		{
+			desc:         "get_fails",
+			getFails:     true,
+			requestState: "",
+			wantErr:      true,
+			wantResp:     false,
+		},
+		{
+			desc:          "timeout",
+			getFails:      false,
+			requestAction: RequestCreateAction,
+			requestState:  "ANOTHER Status",
+			wantErr:       true,
+			wantResp:      true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.desc, func(t *testing.T) {
+			apiClient := &apiClientMocked{
+				getProjectRequestFails: tt.getFails,
+				requestAction:          tt.requestAction,
+				resourceState:          tt.requestState,
+			}
+
+			var wantRes *iaasalpha.Request
+			if tt.wantResp {
+				wantRes = &iaasalpha.Request{
+					RequestId:     utils.Ptr("rid"),
+					RequestAction: &tt.requestAction,
+					Status:        &tt.requestState,
+				}
+			}
+
+			handler := ProjectRequestWaitHandler(context.Background(), apiClient, "pid", "rid")
+
+			gotRes, err := handler.SetTimeout(10 * time.Millisecond).WaitWithContext(context.Background())
+
+			if (err != nil) != tt.wantErr {
+				t.Fatalf("handler error = %v, wantErr %v", err, tt.wantErr)
+			}
+			if !cmp.Equal(gotRes, wantRes) {
+				t.Fatalf("handler gotRes = %v, want %v", gotRes, wantRes)
+			}
+		})
+	}
+}