Skip to content

Commit 43fc36e

Browse files
marceljkmarceljk
committed
review feedback
- extended CHANGELOG - renamed DeleteNetworkAreaRegionWaitHandler to be aligned with the associated method
1 parent cb098d3 commit 43fc36e

File tree

5 files changed

+26
-12
lines changed

5 files changed

+26
-12
lines changed

‎CHANGELOG.md‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,19 @@
66
- **Deprecation:** `StorageUpdate`: updating the performance class field is not possible.
77
- `iaas`: [v1.0.0](services/iaas/CHANGELOG.md#v100)
88
- **Breaking Change:** The region is no longer specified within the client configuration. Instead, the region must be passed as a parameter to any region-specific request.
9-
- **Feature:** Add new methods to manage routing tables: `AddRoutingTableToArea`, `DeleteRoutingTableFromArea`, `GetRoutingTableOfArea`, `ListRoutingTablesOfArea` and `UpdateRoutingTableOfArea`
10-
- **Feature:** Add new methods to manage routes in routing tables: `AddRoutesToRoutingTable`, `DeleteRouteFromRoutingTable`, `GetRouteOfRoutingTable`, `ListRoutesOfRoutingTable` and `UpdateRouteOfRoutingTable`
11-
- **Breaking Change:** Add new method to manage network area regions: `CreateNetworkAreaRegion`, `DeleteNetworkAreaRegion`, `GetNetworkAreaRegion`, `ListNetworkAreaRegions` and `UpdateNetworkAreaRegion`
9+
- **Feature:** Add new methods to manage routing tables: `AddRoutingTableToArea`, `DeleteRoutingTableFromArea`, `GetRoutingTableOfArea`, `ListRoutingTablesOfArea`, `UpdateRoutingTableOfArea`
10+
- **Feature:** Add new methods to manage routes in routing tables: `AddRoutesToRoutingTable`, `DeleteRouteFromRoutingTable`, `GetRouteOfRoutingTable`, `ListRoutesOfRoutingTable`, `UpdateRouteOfRoutingTable`
11+
- **Breaking Change:** Add new method to manage network area regions: `CreateNetworkAreaRegion`, `DeleteNetworkAreaRegion`, `GetNetworkAreaRegion`, `ListNetworkAreaRegions`, `UpdateNetworkAreaRegion`
1212
- **Feature:** Add new wait handler for network area region: `CreateNetworkAreaRegionWaitHandler` and `DeleteRegionalNetworkAreaConfigurationWaitHandler`
13+
- **Breaking Change:** Wait handler which relates to region-specific services, got an additional param for the region: `CreateNetworkWaitHandler`, `UpdateNetworkWaitHandler`, `DeleteNetworkWaitHandler`, `CreateVolumeWaitHandler`, `DeleteVolumeWaitHandler`, `CreateServerWaitHandler`, `ResizeServerWaitHandler`, `DeleteServerWaitHandler`, `StartServerWaitHandler`, `StopServerWaitHandler`, `DeallocateServerWaitHandler`, `RescueServerWaitHandler`, `UnrescueServerWaitHandler`, `ProjectRequestWaitHandler`, `AddVolumeToServerWaitHandler`, `RemoveVolumeFromServerWaitHandler`, `UploadImageWaitHandler`, `DeleteImageWaitHandler`, `CreateBackupWaitHandler`, `DeleteBackupWaitHandler`, `RestoreBackupWaitHandler`, `CreateSnapshotWaitHandler`, `DeleteSnapshotWaitHandler`
14+
- **Breaking Change:** `Network` model has changed:
15+
- `NetworkId` has been renamed to `Id`
16+
- `Gateway`, `Nameservers`, `Prefixes` and `PublicIp` has been moved to new model `NetworkIPv4`, and can be accessed in the new property `IPv4`
17+
- Properties `Gatewayv6`, `Nameserversv6` and `Prefixesv6` moved to new model `NetworkIPv6`, and can be accessed in the new property `IPv6`
18+
- **Breaking Change:** `CreateServerPayload` model has changed:
19+
- Model `CreateServerPayloadBootVolume` of `BootVolume` property changed to `ServerBootVolume`
20+
- Property `Networking` in `CreateServerPayload` is required now
1321
- **Deprecated:** Deprecated wait handler and will be removed after April 2026: `CreateNetworkAreaWaitHandler`, `UpdateNetworkAreaWaitHandler` and `DeleteNetworkAreaWaitHandler`
14-
- Migrate iaas examples to the new iaas methods
1522

1623
## Release (2025-10-13)
1724
- `observability`: [v0.15.0](services/observability/CHANGELOG.md#v0150)

‎examples/iaas/network_area/network_area.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func main() {
117117
fmt.Fprintf(os.Stderr, "[IaaS API] Error when calling `DeleteNetworkAreaRegion`: %v\n", err)
118118
}
119119

120-
_, err = wait.DeleteRegionalNetworkAreaConfigurationWaitHandler(context.Background(), iaasClient, organizationId, *updatedArea.Id, region).WaitWithContext(context.Background())
120+
_, err = wait.DeleteNetworkAreaRegionWaitHandler(context.Background(), iaasClient, organizationId, *updatedArea.Id, region).WaitWithContext(context.Background())
121121
if err != nil {
122122
fmt.Fprintf(os.Stderr, "[IaaS API] Error when waiting for network configuration deletion: %v\n", err)
123123
os.Exit(1)

‎services/iaas/CHANGELOG.md‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,15 @@
44
- **Feature:** Add new methods to manage routes in routing tables: `AddRoutesToRoutingTable`, `DeleteRouteFromRoutingTable`, `GetRouteOfRoutingTable`, `ListRoutesOfRoutingTable`, `UpdateRouteOfRoutingTable`
55
- **Breaking Change:** Add new method to manage network area regions: `CreateNetworkAreaRegion`, `DeleteNetworkAreaRegion`, `GetNetworkAreaRegion`, `ListNetworkAreaRegions`, `UpdateNetworkAreaRegion`
66
- **Feature:** Add new wait handler for network area region: `CreateNetworkAreaRegionWaitHandler` and `DeleteRegionalNetworkAreaConfigurationWaitHandler`
7+
- **Breaking Change:** Wait handler which relates to region-specific services, got an additional param for the region: `CreateNetworkWaitHandler`, `UpdateNetworkWaitHandler`, `DeleteNetworkWaitHandler`, `CreateVolumeWaitHandler`, `DeleteVolumeWaitHandler`, `CreateServerWaitHandler`, `ResizeServerWaitHandler`, `DeleteServerWaitHandler`, `StartServerWaitHandler`, `StopServerWaitHandler`, `DeallocateServerWaitHandler`, `RescueServerWaitHandler`, `UnrescueServerWaitHandler`, `ProjectRequestWaitHandler`, `AddVolumeToServerWaitHandler`, `RemoveVolumeFromServerWaitHandler`, `UploadImageWaitHandler`, `DeleteImageWaitHandler`, `CreateBackupWaitHandler`, `DeleteBackupWaitHandler`, `RestoreBackupWaitHandler`, `CreateSnapshotWaitHandler`, `DeleteSnapshotWaitHandler`
8+
- **Breaking Change:** `Network` model has changed:
9+
- `NetworkId` has been renamed to `Id`
10+
- `Gateway`, `Nameservers`, `Prefixes` and `PublicIp` has been moved to new model `NetworkIPv4`, and can be accessed in the new property `IPv4`
11+
- Properties `Gatewayv6`, `Nameserversv6` and `Prefixesv6` moved to new model `NetworkIPv6`, and can be accessed in the new property `IPv6`
12+
- **Breaking Change:** `CreateServerPayload` model has changed:
13+
- Model `CreateServerPayloadBootVolume` of `BootVolume` property changed to `ServerBootVolume`
14+
- Property `Networking` in `CreateServerPayload` is required now
715
- **Deprecated:** Deprecated wait handler and will be removed after April 2026: `CreateNetworkAreaWaitHandler`, `UpdateNetworkAreaWaitHandler` and `DeleteNetworkAreaWaitHandler`
8-
- Migrate iaas examples to the new iaas methods
916

1017
## v0.31.0
1118
- Add `CreatedAt` and `UpdatedAt` fields to `BaseSecurityGroupRule` struct

‎services/iaas/wait/wait.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func UpdateNetworkAreaWaitHandler(ctx context.Context, a APIClientInterface, org
105105
return handler
106106
}
107107

108-
// CreateNetworkAreaRegionWaitHandler will wait for network area update
108+
// CreateNetworkAreaRegionWaitHandler will wait for network area region creation
109109
func CreateNetworkAreaRegionWaitHandler(ctx context.Context, a APIClientInterface, organizationId, areaId, region string) *wait.AsyncActionHandler[iaas.RegionalArea] {
110110
handler := wait.New(func() (waitFinished bool, response *iaas.RegionalArea, err error) {
111111
area, err := a.GetNetworkAreaRegionExecute(ctx, organizationId, areaId, region)
@@ -126,8 +126,8 @@ func CreateNetworkAreaRegionWaitHandler(ctx context.Context, a APIClientInterfac
126126
return handler
127127
}
128128

129-
// DeleteRegionalNetworkAreaConfigurationWaitHandler will wait for network area update
130-
func DeleteRegionalNetworkAreaConfigurationWaitHandler(ctx context.Context, a APIClientInterface, organizationId, areaId, region string) *wait.AsyncActionHandler[iaas.RegionalArea] {
129+
// DeleteNetworkAreaRegionWaitHandler will wait for network area region deletion
130+
func DeleteNetworkAreaRegionWaitHandler(ctx context.Context, a APIClientInterface, organizationId, areaId, region string) *wait.AsyncActionHandler[iaas.RegionalArea] {
131131
handler := wait.New(func() (waitFinished bool, response *iaas.RegionalArea, err error) {
132132
area, err := a.GetNetworkAreaRegionExecute(ctx, organizationId, areaId, region)
133133
if err == nil {

‎services/iaas/wait/wait_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1878,7 +1878,7 @@ func TestReadyForNetworkAreaDeletionWaitHandler(t *testing.T) {
18781878
}
18791879
}
18801880

1881-
func TestCreateRegionalNetworkAreaConfigurationWaitHandler(t *testing.T) {
1881+
func TestCreateNetworkAreaRegionWaitHandler(t *testing.T) {
18821882
tests := []struct {
18831883
desc string
18841884
getFails bool
@@ -1936,7 +1936,7 @@ func TestCreateRegionalNetworkAreaConfigurationWaitHandler(t *testing.T) {
19361936
}
19371937
}
19381938

1939-
func TestDeleteRegionalNetworkAreaConfigurationWaitHandler(t *testing.T) {
1939+
func TestDeleteNetworkAreaRegionWaitHandler(t *testing.T) {
19401940
tests := []struct {
19411941
desc string
19421942
getFails bool
@@ -1982,7 +1982,7 @@ func TestDeleteRegionalNetworkAreaConfigurationWaitHandler(t *testing.T) {
19821982
}
19831983
}
19841984

1985-
handler := DeleteRegionalNetworkAreaConfigurationWaitHandler(context.Background(), apiClient, "pid", "region", "nid")
1985+
handler := DeleteNetworkAreaRegionWaitHandler(context.Background(), apiClient, "pid", "region", "nid")
19861986

19871987
gotRes, err := handler.SetTimeout(10 * time.Millisecond).WaitWithContext(context.Background())
19881988

0 commit comments

Comments
 (0)