feat: return cluster error messages on wait handler

Author: h3adex

services/ske/wait/wait.go

@@ -3,6 +3,7 @@ package wait
 import (
 	"context"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/stackitcloud/stackit-sdk-go/core/wait"
@@ -56,6 +57,18 @@ func CreateOrUpdateClusterWaitHandler(ctx context.Context, a APIClientClusterInt
 			return true, s, nil
 		}
 
+		// TODO: discuss if we should check for cluster state?
+		if s.Status.Errors != nil && len(*s.Status.Errors) > 0 {
+			var errMsgs []string
+			for _, clusterError := range *s.Status.Errors {
+				if clusterError.Message != nil && clusterError.Code != nil {
+					errMsgs = append(errMsgs, fmt.Sprintf("%s %s", *clusterError.Code, *clusterError.Message))
+				}
+			}
+
+			return true, s, fmt.Errorf(strings.Join(errMsgs, "\n"))
+		}
+
 		if state == ske.CLUSTERSTATUSSTATE_HEALTHY || state == ske.CLUSTERSTATUSSTATE_HIBERNATED {
 			return true, s, nil
 		}

services/ske/wait/wait_test.go

@@ -18,6 +18,7 @@ type apiClientClusterMocked struct {
 	name                 string
 	resourceState        ske.ClusterStatusState
 	invalidArgusInstance bool
+	errorList            *[]ske.ClusterError
 }
 
 const testRegion = "eu01"
@@ -45,7 +46,17 @@ func (a *apiClientClusterMocked) GetClusterExecute(_ context.Context, _, _, _ st
 	return &ske.Cluster{
 		Name: utils.Ptr("cluster"),
 		Status: &ske.ClusterStatus{
-			Aggregated: &rs,
+			Aggregated: utils.Ptr(rs),
+			Error: func() *ske.RuntimeError {
+				if a.invalidArgusInstance {
+					return &ske.RuntimeError{
+						Code:    utils.Ptr(ske.RUNTIMEERRORCODE_OBSERVABILITY_INSTANCE_NOT_FOUND),
+						Message: utils.Ptr("invalid argus instance"),
+					}
+				}
+				return nil
+			}(),
+			Errors: a.errorList,
 		},
 	}, nil
 }
@@ -77,6 +88,7 @@ func TestCreateOrUpdateClusterWaitHandler(t *testing.T) {
 		invalidArgusInstance bool
 		wantErr              bool
 		wantResp             bool
+		errorList            *[]ske.ClusterError
 	}{
 		{
 			desc:          "create_succeeded",
@@ -120,6 +132,23 @@ func TestCreateOrUpdateClusterWaitHandler(t *testing.T) {
 			wantErr:       true,
 			wantResp:      false,
 		},
+		{
+			desc:          "status_errors_present",
+			getFails:      false,
+			resourceState: ske.CLUSTERSTATUSSTATE_CREATING,
+			errorList: &[]ske.ClusterError{
+				{
+					Code:    utils.Ptr("ERR_CODE"),
+					Message: utils.Ptr("Error 1"),
+				},
+				{
+					Code:    utils.Ptr("ERR_OTHER"),
+					Message: utils.Ptr("Error 2"),
+				},
+			},
+			wantErr:  true,
+			wantResp: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.desc, func(t *testing.T) {
@@ -130,6 +159,7 @@ func TestCreateOrUpdateClusterWaitHandler(t *testing.T) {
 				name:                 name,
 				resourceState:        tt.resourceState,
 				invalidArgusInstance: tt.invalidArgusInstance,
+				errorList:            tt.errorList,
 			}
 			var wantRes *ske.Cluster
 			rs := ske.ClusterStatusState(tt.resourceState)
@@ -147,6 +177,10 @@ func TestCreateOrUpdateClusterWaitHandler(t *testing.T) {
 						Message: utils.Ptr("invalid argus instance"),
 					}
 				}
+
+				if tt.errorList != nil && len(*tt.errorList) > 0 {
+					wantRes.Status.Errors = tt.errorList
+				}
 			}
 
 			handler := CreateOrUpdateClusterWaitHandler(context.Background(), apiClient, "", testRegion, name)