Skip to content

Conversation

@PatrickKoss
Copy link
Contributor

No description provided.

Copy link
Contributor

@Fyusel Fyusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add the two changelog entries as well please?

@PatrickKoss
Copy link
Contributor Author

Looks good! Can you add the two changelog entries as well please?

@Fyusel I am not sure what is generated and what not and where to add it in the change log. Should I add an entry in the model-serving folder like

## v0.2.0 (2025-03-10)

- **New**: STACKIT Model Serving module wait handler added.

## v0.1.0 (2025-02-25)

- **New**: STACKIT Model Serving module can be used to manage the STACKIT Model Serving.

And potentially also in the root Changelog like:

## Release (2025-03-10)
- `model-serving`: [v0.2.0](services/modelserving/CHANGELOG.md#v020-2025-03-10)

## Release (2025-03-05)

- `core`: [v0.16.1](core/CHANGELOG.md#v0161-2025-02-25)
  - **Bugfix:** STACKIT_PRIVATE_KEY and STACKIT_SERVICE_ACCOUNT_KEY can be set via environment variable or via credentials file.

???

@Fyusel
Copy link
Contributor

Fyusel commented Mar 11, 2025

Looks good! Can you add the two changelog entries as well please?

@Fyusel I am not sure what is generated and what not and where to add it in the change log. Should I add an entry in the model-serving folder like

## v0.2.0 (2025-03-10)

- **New**: STACKIT Model Serving module wait handler added.

## v0.1.0 (2025-02-25)

- **New**: STACKIT Model Serving module can be used to manage the STACKIT Model Serving.

And potentially also in the root Changelog like:

## Release (2025-03-10)
- `model-serving`: [v0.2.0](services/modelserving/CHANGELOG.md#v020-2025-03-10)

## Release (2025-03-05)

- `core`: [v0.16.1](core/CHANGELOG.md#v0161-2025-02-25)
  - **Bugfix:** STACKIT_PRIVATE_KEY and STACKIT_SERVICE_ACCOUNT_KEY can be set via environment variable or via credentials file.

???

Yes, that is correct except that in the root changelog the release date is 2025-XX-XX and also the one line should be added there "New: STACKIT Model Serving module wait handler added.".

@PatrickKoss
Copy link
Contributor Author

Looks good! Can you add the two changelog entries as well please?

@Fyusel I am not sure what is generated and what not and where to add it in the change log. Should I add an entry in the model-serving folder like

## v0.2.0 (2025-03-10)

- **New**: STACKIT Model Serving module wait handler added.

## v0.1.0 (2025-02-25)

- **New**: STACKIT Model Serving module can be used to manage the STACKIT Model Serving.

And potentially also in the root Changelog like:

## Release (2025-03-10)
- `model-serving`: [v0.2.0](services/modelserving/CHANGELOG.md#v020-2025-03-10)

## Release (2025-03-05)

- `core`: [v0.16.1](core/CHANGELOG.md#v0161-2025-02-25)
  - **Bugfix:** STACKIT_PRIVATE_KEY and STACKIT_SERVICE_ACCOUNT_KEY can be set via environment variable or via credentials file.

???

Yes, that is correct except that in the root changelog the release date is 2025-XX-XX and also the one line should be added there "New: STACKIT Model Serving module wait handler added.".

Added the change log. Can you check again?

@Fyusel Fyusel merged commit 97dfe71 into stackitcloud:main Mar 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants