Potentially improve task insert performance by using hashed random id as task name

Author: marickvantuil

src/CloudTasksQueue.php

@@ -20,7 +20,6 @@
 
 use function Safe\json_decode;
 use function Safe\json_encode;
-use function Safe\preg_replace;
 
 class CloudTasksQueue extends LaravelQueue implements QueueContract
 {
@@ -113,7 +112,7 @@ protected function pushToCloudTasks($queue, $payload, $delay = 0)
 
         $payload = (array) json_decode($payload, true);
 
-        $task = tap(new Task())->setName($this->taskName($queue, $payload));
+        $task = tap(new Task())->setName($this->taskName($queue));
 
         $payload = $this->enrichPayloadWithInternalData(
             payload: $payload,
@@ -144,29 +143,16 @@ protected function pushToCloudTasks($queue, $payload, $delay = 0)
         return $payload['uuid'];
     }
 
-    private function taskName(string $queueName, array $payload): string
+    private function taskName(string $queueName): string
     {
-        $displayName = $this->sanitizeTaskName($payload['displayName']);
-
         return CloudTasksClient::taskName(
             $this->config['project'],
             $this->config['location'],
             $queueName,
-            $displayName.'-'.bin2hex(random_bytes(8)),
+            bin2hex(random_bytes(16)),
         );
     }
 
-    private function sanitizeTaskName(string $taskName): string
-    {
-        // Remove all characters that are not -, letters, numbers, or whitespace
-        $sanitizedName = preg_replace('![^-\pL\pN\s]+!u', '-', $taskName);
-
-        // Replace all separator characters and whitespace by a -
-        $sanitizedName = preg_replace('![-\s]+!u', '-', $sanitizedName);
-
-        return trim($sanitizedName, '-');
-    }
-
     private function enrichPayloadWithInternalData(
         array $payload,
         string $queueName,

tests/QueueTest.php

@@ -436,7 +436,7 @@ public function test_ignoring_jobs_with_deleted_models()
     }
 
     #[Test]
-    public function it_adds_a_task_name_based_on_the_display_name()
+    public function it_adds_a_pre_defined_task_name()
     {
         // Arrange
         CloudTasksApi::fake();
@@ -446,10 +446,7 @@ public function it_adds_a_task_name_based_on_the_display_name()
 
         // Assert
         CloudTasksApi::assertTaskCreated(function (Task $task): bool {
-            return str_starts_with(
-                $task->getName(),
-                'projects/my-test-project/locations/europe-west6/queues/barbequeue/tasks/Tests-Support-SimpleJob'
-            );
+            return str($task->getName())->test('/projects\/.+\/locations\/.+\/queues\/.+\/tasks\/[a-z0-9]{16}/');
         });
     }