Fixed test coverage to match 100%

Author: larsvankleef

src/validation/__tests__/number.test.js

@@ -18,3 +18,10 @@ it('validates that a given number is higher then the min value', () => {
   expect(number(value, { min: 9 })).toEqual(true)
   expect(number(value, { min: 11 })).toEqual(false)
 })
+
+it('validates tht a given number is between the given range', () => {
+  const value = 10
+
+  expect(number(value, { min: 9, max: 11 })).toEqual(true)
+  expect(number(value, { min: 8, max: 9 })).toEqual(false)
+})

src/validation/index.js

@@ -1,10 +1,8 @@
 function number(x, { max, min } = {}) {
-  if (min || max) {
-    if (Number(x) === x) {
-      if (x >= min && x <= max) return true
-      if (x >= min && max === undefined) return true
-      if (x <= max && min === undefined) return true
-    }
+  if ((min || max) && Number(x) === x) {
+    if (x >= min && x <= max) return true
+    if (x >= min && max === undefined) return true
+    if (x <= max && min === undefined) return true
   }
 
   if (Number(x) === x && min === undefined && max === undefined) {