Fix minor typo in Vault tutorial, add missing CRDs upgrade step #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Barr <[email protected]>
Signed-off-by: Dan Barr <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues in the ToolHive Kubernetes documentation: corrects a container name typo in the Vault tutorial verification step and adds a missing CRDs upgrade step to the operator deployment guide.
Key changes:
- Fixed container name from "toolhive" to "vault-agent" in the Vault tutorial verification command
- Added proper CRDs upgrade step before operator upgrade in the deployment guide
- Updated example version numbers to current releases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/toolhive/tutorials/vault-integration.mdx | Fixed container name typo in kubectl exec command and improved introduction text |
| docs/toolhive/guides-k8s/deploy-operator-helm.md | Added missing CRDs upgrade step and updated version examples |
jhrozek
approved these changes
Sep 9, 2025
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I can't tell if copilot's suggestion is correct or not
Collaborator
Author
It's a bit pedantic, I dismissed it 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes container name for the verification step in the K8s/Vault tutorial.
Also adds a missing step to upgrade the CRDs helm chart before upgrading the Operator itself.
Merge checklist
Content
sidebars.ts) updated for added, deleted, reordered, or renamed filesvercel.jsonfor moved, renamed, or deleted pages (i.e., if the URL slug changed)Reviews
Signed-off-by: Dan Barr [email protected]