Skip to content

Temporary fix for new early exit behavior in thv #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

Temporary fix for new early exit behavior in thv #189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4452de
Temporary fix for new early exit behavior in thv
danbarr Sep 18, 2025
a488410
Fix URL
danbarr Sep 18, 2025
1216403
Fix version
danbarr Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions scripts/install-thv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,28 @@ if ! command -v jq >/dev/null 2>&1; then
exit 1
fi

API_ENDPOINT="https://api.github.com/repos/stacklok/toolhive/releases/latest"
#API_ENDPOINT="https://api.github.com/repos/stacklok/toolhive/releases/latest"

# Fetch release information
RELEASE_JSON=$(curl -sf "$API_ENDPOINT" || {
echo "Failed to fetch release information from GitHub API"
exit 1
})
RELEASE_VERSION=$(echo "$RELEASE_JSON" | jq -r '.tag_name // empty' | sed 's/^v//')
RELEASE_TARBALL=$(echo "$RELEASE_JSON" | jq -r \
--arg version "$RELEASE_VERSION" \
'.assets[] | select(.name == "toolhive_" + $version + "_linux_amd64.tar.gz") | .browser_download_url // empty')
#RELEASE_JSON=$(curl -sf "$API_ENDPOINT" || {
# echo "Failed to fetch release information from GitHub API"
# exit 1
#})
#RELEASE_VERSION=$(echo "$RELEASE_JSON" | jq -r '.tag_name // empty' | sed 's/^v//')
#RELEASE_TARBALL=$(echo "$RELEASE_JSON" | jq -r \
# --arg version "$RELEASE_VERSION" \
# '.assets[] | select(.name == "toolhive_" + $version + "_linux_amd64.tar.gz") | .browser_download_url // empty')

if [ -z "$RELEASE_TARBALL" ]; then
echo "Failed to get release tarball URL for release: ${RELEASE_VERSION}"
echo "Please check if the tag exists in the repository"
exit 1
fi
#if [ -z "$RELEASE_TARBALL" ]; then
# echo "Failed to get release tarball URL for release: ${RELEASE_VERSION}"
# echo "Please check if the tag exists in the repository"
# exit 1
#fi

# Temporary fix for early exit if container runtime isn't found

RELEASE_VERSION="v0.2.17"
RELEASE_TARBALL="https://github.com/stacklok/toolhive/releases/download/v0.2.17/toolhive_0.2.17_linux_amd64.tar.gz"

# Determine installation location based on write permissions
if [[ -w "/usr/local/bin" ]]; then
Expand Down