Fail production builds on MCPMetadata fetch errors #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a mechanism to fail production builds when MCPMetadata fetch operations encounter errors, enhancing build reliability in production environments. It also adds verification to ensure the ToolHive CLI installation is working correctly.
Key changes:
- Added
failOnErroroption to the MCP metadata plugin that throws errors in production/CI environments instead of falling back to error messages - Enhanced the ToolHive installation script with post-installation verification
- Configured production builds to enable strict error handling for MCP metadata fetching
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/mcp-metadata-plugin/src/types.ts |
Added failOnError boolean option to plugin configuration interface |
plugins/mcp-metadata-plugin/src/index.ts |
Implemented error throwing logic when failOnError is enabled, replacing graceful fallback behavior |
docusaurus.config.ts |
Configured plugin to enable failOnError in production and CI environments |
scripts/install-thv.sh |
Added post-installation verification by running thv version command with error handling |
danbarr
force-pushed
the
harden-mcpmeta-builds
branch
from
20011e7 to
0ce92c9
Compare
Signed-off-by: Dan Barr <[email protected]>
Signed-off-by: Dan Barr <[email protected]>
danbarr
force-pushed
the
harden-mcpmeta-builds
branch
from
0ce92c9 to
adf6e14
Compare
Signed-off-by: Dan Barr <[email protected]>
rdimitrov
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a mechanism to fail production builds if the MCPMetadata fetch fails and add a verification step for the thv installation.
Also reverts the temporary pinning to v0.2.17. The early exit was removed for informational commands in v0.3.3.