cleanup

Author: kantord

README.md

@@ -262,26 +262,26 @@ BETTER_AUTH_URL=http://localhost:3000
 
 ### Testing
 
+#### Unit/Component Tests
+
 ```bash
-# Run all tests
-pnpm test
+pnpm test              # Run all tests
+pnpm test --watch      # Watch mode
+pnpm test --coverage   # With coverage
+```
 
-# Run tests in watch mode
-pnpm test --watch
+Uses Vitest + Testing Library + MSW.
 
-# Run tests with coverage
-pnpm test --coverage
+#### BDD E2E Tests (Cucumber + Playwright)
 
-# Run specific test file
-pnpm test src/components/navbar.test.tsx
+```bash
+pnpm exec playwright install   # One-time browser install
+pnpm dev                       # Start dev stack
+pnpm run test:bdd              # Run scenarios (headless)
+pnpm run test:bdd:debug        # With Playwright Inspector
+pnpm run test:bdd:trace        # Capture traces
 ```
 
-Tests use:
-
-- **Vitest** - Test runner
-- **Testing Library** - React component testing
-- **MSW** - API mocking
-
 ### Mock Server
 
 The project includes a standalone MSW mock server for development:

tests/bdd/features/catalog.feature

@@ -3,4 +3,4 @@ Feature: Catalog page
   Scenario: View catalog page header
     Given I am logged in
     And I am on "/catalog"
-    Then I should see a heading "MCP Server Catalog"
+    Then I should see an "MCP Server Catalog" heading

tests/bdd/features/login.feature

@@ -4,7 +4,7 @@ Feature: Login flow
     Given I am on "/signin"
     When I click on the "Okta" button
     Then I should be on "/catalog"
-    And I should see a heading "MCP Server Catalog"
+    And I should see an "MCP Server Catalog" heading
 
   Scenario: Log out from Catalog
     Given I am logged in

tests/bdd/steps/global.steps.ts

@@ -26,8 +26,8 @@ Then(
 );
 
 Then(
-  "I should see a heading {string}",
-  async function (this: PlaywrightWorld, heading: string) {
+  "I should see {article} {string} heading",
+  async function (this: PlaywrightWorld, _article: null, heading: string) {
     await expect(
       this.requirePage().getByRole("heading", { name: heading }),
     ).toBeVisible();

tests/bdd/support/parameter-types.ts

@@ -17,3 +17,10 @@ defineParameterType({
     throw new Error(`Unknown role phrase "${text}".`);
   },
 });
+
+defineParameterType({
+  name: "article",
+  useForSnippets: false,
+  regexp: /a|an/,
+  transformer: () => null,
+});