remove cucumber

Author: kantord

.github/workflows/bdd.yml

@@ -1,4 +1,4 @@
-name: BDD E2E
+name: E2E Tests
 
 on:
   push:
@@ -11,9 +11,9 @@ permissions:
 
 jobs:
   e2e:
-    name: Run BDD (Cucumber + Playwright)
+    name: Playwright E2E
     runs-on: ubuntu-latest
-    timeout-minutes: 20
+    timeout-minutes: 15
     steps:
       - name: Checkout
         uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
@@ -22,7 +22,7 @@ jobs:
         uses: ./.github/actions/setup
 
       - name: Install Playwright browsers
-        run: pnpm exec playwright install --with-deps
+        run: pnpm exec playwright install --with-deps chromium
 
       - name: Start dev stack (Next + OIDC + Mock)
         env:
@@ -40,7 +40,7 @@ jobs:
           for url in http://localhost:3000 http://localhost:4000/.well-known/openid-configuration http://localhost:9090/health; do
             echo "Waiting for $url..."
             up=false
-            for i in {1..60}; do
+            for i in {1..30}; do
               if curl -sf "$url" >/dev/null; then
                 echo "$url is up"
                 up=true
@@ -54,13 +54,22 @@ jobs:
             fi
           done
 
-      - name: Run BDD tests
+      - name: Run Playwright tests
         env:
           BASE_URL: http://localhost:3000
-        run: pnpm run test:bdd
+        run: pnpm run test:e2e
+
+      - name: Upload test artifacts
+        uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: playwright-report
+          path: |
+            test-results/
+            playwright-report/
+          retention-days: 7
 
       - name: Cleanup dev
         if: always()
         run: |
           if [ -f dev.pid ]; then kill $(cat dev.pid) || true; fi
-

CLAUDE.md

@@ -222,18 +222,18 @@ pnpm generate-client:nofetch # Regenerate without fetching
 - **Testing Library** - Component testing
 - **jsdom** - DOM simulation
 
-### BDD E2E (Cucumber + Playwright)
+### E2E Tests (Playwright)
 
-- End-to-end scenarios live under `tests/bdd` and run against a live dev stack.
+- End-to-end tests live under `tests/e2e` and run against a live dev stack.
 - Commands:
   - `pnpm dev` – starts Next.js (3000), mock OIDC (4000), and MSW mock API (9090)
-  - `pnpm run test:bdd` – runs Cucumber scenarios with Playwright (headless)
-  - `pnpm run test:bdd:debug` – runs with Playwright Inspector (headed, pauses on start)
-  - `pnpm run test:bdd:trace` – runs with Playwright tracing, artifacts in `test-results/traces/*.zip`
-- CI runs BDD tests via `.github/workflows/bdd.yml` and installs Playwright browsers.
+  - `pnpm run test:e2e` – runs Playwright tests (headless)
+  - `pnpm run test:e2e:ui` – opens Playwright UI mode for interactive debugging
+  - `pnpm run test:e2e:debug` – runs with Playwright Inspector
+- CI runs E2E tests via `.github/workflows/bdd.yml` and installs Playwright browsers.
 - Install browsers locally once: `pnpm exec playwright install`
 
-Scaffolded global steps include navigation, clicking buttons by accessible name, URL assertions, and text/heading checks. Prefer reusing global steps; add domain-specific ones only when needed for clarity.
+Tests use custom fixtures for authentication. The `authenticatedPage` fixture handles login automatically.
 
 ### Example Test
 

README.md

@@ -285,14 +285,14 @@ pnpm test --coverage   # With coverage
 
 Uses Vitest + Testing Library + MSW.
 
-#### BDD E2E Tests (Cucumber + Playwright)
+#### E2E Tests (Playwright)
 
 ```bash
 pnpm exec playwright install   # One-time browser install
 pnpm dev                       # Start dev stack
-pnpm run test:bdd              # Run scenarios (headless)
-pnpm run test:bdd:debug        # With Playwright Inspector
-pnpm run test:bdd:trace        # Capture traces
+pnpm run test:e2e              # Run tests (headless)
+pnpm run test:e2e:ui           # Playwright UI mode
+pnpm run test:e2e:debug        # With Playwright Inspector
 ```
 
 ### Mock Server
@@ -479,16 +479,16 @@ pnpm type-check      # TypeScript
 pnpm lint            # Biome
 ```
 
-### BDD E2E (Cucumber + Playwright)
+### E2E Tests (Playwright)
 
 Run the app and E2E tests locally:
 
 ```bash
 pnpm exec playwright install   # one-time browser install
 pnpm dev                       # start Next (3000) + OIDC (4000) + Mock API (9090)
-pnpm run test:bdd              # run Cucumber scenarios (headless)
-pnpm run test:bdd:debug        # headed with Playwright Inspector (PWDEBUG=1)
-pnpm run test:bdd:trace        # capture Playwright traces (PWTRACE=1)
+pnpm run test:e2e              # run Playwright tests (headless)
+pnpm run test:e2e:ui           # Playwright UI mode for debugging
+pnpm run test:e2e:debug        # with Playwright Inspector
 ```
 
 CI runs the E2E suite via `.github/workflows/bdd.yml`.

cucumber.js

@@ -13,9 +13,9 @@
     "lint": "biome check",
     "format": "biome format --write",
     "test": "vitest",
-    "test:bdd": "cucumber-js",
-    "test:bdd:trace": "PWTRACE=1 cucumber-js",
-    "test:bdd:debug": "PWDEBUG=1 cucumber-js",
+    "test:e2e": "playwright test",
+    "test:e2e:ui": "playwright test --ui",
+    "test:e2e:debug": "playwright test --debug",
     "type-check": "tsc --noEmit",
     "prepare": "husky",
     "oidc": "node dev-auth/oidc-provider.mjs",
@@ -51,8 +51,6 @@
   },
   "devDependencies": {
     "@biomejs/biome": "2.3.8",
-    "@cucumber/cucumber": "^12.2.0",
-    "@cucumber/messages": "^31.0.0",
     "@hey-api/client-next": "0.5.1",
     "@hey-api/openapi-ts": "0.89.0",
     "@mswjs/http-middleware": "^0.10.2",
@@ -66,7 +64,6 @@
     "@types/react": "^19",
     "@types/react-dom": "^19",
     "@vitejs/plugin-react": "^5.1.1",
-    "aria-query": "^5.3.2",
     "babel-plugin-react-compiler": "1.0.0",
     "concurrently": "^9.2.1",
     "dotenv": "^17.2.3",
@@ -75,7 +72,6 @@
     "lint-staged": "^16.0.0",
     "oidc-provider": "^9.5.2",
     "tailwindcss": "^4",
-    "ts-node": "^10.9.2",
     "tsx": "4.21.0",
     "typescript": "^5",
     "vite": "^7.2.2",

package.json

@@ -0,0 +1,41 @@
+import { defineConfig, devices } from "@playwright/test";
+
+const BASE_URL = process.env.BASE_URL || "http://localhost:3000";
+
+export default defineConfig({
+  testDir: "./tests/e2e",
+  fullyParallel: true,
+  forbidOnly: !!process.env.CI,
+  retries: process.env.CI ? 2 : 0,
+  workers: process.env.CI ? 1 : undefined,
+  reporter: process.env.CI ? "github" : "list",
+  timeout: 30_000,
+  use: {
+    baseURL: BASE_URL,
+    trace: "on-first-retry",
+    screenshot: "only-on-failure",
+  },
+  projects: [
+    {
+      name: "chromium",
+      use: { ...devices["Desktop Chrome"] },
+    },
+  ],
+  webServer: {
+    command: "pnpm dev",
+    url: BASE_URL,
+    reuseExistingServer: !process.env.CI,
+    timeout: 120_000,
+    stdout: "pipe",
+    stderr: "pipe",
+    env: {
+      API_BASE_URL: "http://localhost:9090",
+      OIDC_ISSUER_URL: "http://localhost:4000",
+      OIDC_CLIENT_ID: "better-auth-dev",
+      OIDC_CLIENT_SECRET: "dev-secret-change-in-production",
+      NEXT_PUBLIC_OIDC_PROVIDER_ID: "okta",
+      BETTER_AUTH_URL: "http://localhost:3000",
+      BETTER_AUTH_SECRET: "e2e-test-secret-at-least-32-chars-long",
+    },
+  },
+});