implement review suggestions

Author: kantord

src/mocks/server.ts

@@ -30,6 +30,8 @@ const healthHandler = http.get("*/health", () => {
 const httpServer = createServer(healthHandler, ...handlers);
 
 httpServer.on("request", (req: IncomingMessage, _res: ServerResponse) => {
+  // Skip logging health checks to reduce CI noise
+  if (req.url?.includes("/health")) return;
   console.log(`[mock] ${req.method} ${req.url}`);
 });
 

tests/bdd/steps/global.steps.ts

@@ -4,19 +4,19 @@ import { injectAuthCookies } from "../support/auth.ts";
 import type { PlaywrightWorld } from "../support/world";
 
 Given("I am on {string}", async function (this: PlaywrightWorld, path: string) {
-  await this.page.goto(`${this.baseUrl}${path}`);
+  await this.requirePage().goto(`${this.baseUrl}${path}`);
 });
 
 Given("I am logged in", async function (this: PlaywrightWorld) {
   // Perform login in a separate page and inject cookies into context
-  await injectAuthCookies(this.context);
+  await injectAuthCookies(this.requireContext());
 });
 
 // Generic click step using the {role} parameter type (canonical phrases only)
 When(
   "I click on the {string} {role}",
   async function (this: PlaywrightWorld, label: string, role: AriaRole) {
-    await this.page.getByRole(role, { name: label }).click();
+    await this.requirePage().getByRole(role, { name: label }).click();
   },
 );
 
@@ -25,23 +25,23 @@ When(
 Then(
   "I should see the text {string}",
   async function (this: PlaywrightWorld, text: string) {
-    await expect(this.page.getByText(text)).toBeVisible();
+    await expect(this.requirePage().getByText(text)).toBeVisible();
   },
 );
 
 Then(
   "I should see a heading {string}",
   async function (this: PlaywrightWorld, heading: string) {
     await expect(
-      this.page.getByRole("heading", { name: heading }),
+      this.requirePage().getByRole("heading", { name: heading }),
     ).toBeVisible();
   },
 );
 
 Then(
   "I should be on {string}",
   async function (this: PlaywrightWorld, path: string) {
-    await expect(this.page).toHaveURL(
+    await expect(this.requirePage()).toHaveURL(
       new RegExp(
         `${this.baseUrl}${path.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&")}$`,
       ),

tests/bdd/support/hooks.ts

@@ -50,10 +50,11 @@ Before(async function (this: PlaywrightWorld) {
 After(async function (this: PlaywrightWorld, scenario: ITestCaseHookParameter) {
   if (TRACE_ENABLED && this.context) {
     const safeName = scenario.pickle.name.replace(/[^a-z0-9-]+/gi, "_");
+    const timestamp = new Date().toISOString().replace(/[:.]/g, "-");
     const { mkdir } = await import("node:fs/promises");
     await mkdir("test-results/traces", { recursive: true });
     await this.context.tracing.stop({
-      path: `test-results/traces/${safeName}.zip`,
+      path: `test-results/traces/${safeName}_${timestamp}.zip`,
     });
   }
   if (this.page) await this.page.close();

tests/bdd/support/world.ts

@@ -2,13 +2,25 @@ import { setWorldConstructor, type World } from "@cucumber/cucumber";
 import type { BrowserContext, Page } from "@playwright/test";
 
 export class PlaywrightWorld implements World {
-  page!: Page;
-  context!: BrowserContext;
+  page: Page | undefined;
+  context: BrowserContext | undefined;
   baseUrl: string;
 
   constructor() {
     this.baseUrl = process.env.BASE_URL || "http://localhost:3000";
   }
+
+  requirePage(): Page {
+    if (!this.page)
+      throw new Error("Page not initialized - Before hook may have failed");
+    return this.page;
+  }
+
+  requireContext(): BrowserContext {
+    if (!this.context)
+      throw new Error("Context not initialized - Before hook may have failed");
+    return this.context;
+  }
 }
 
 setWorldConstructor(PlaywrightWorld);