test: remove implicity failures in auto-mocker

Author: kantord

docs/mocks.md

@@ -12,6 +12,9 @@ Usage
 Regeneration
 - Delete a fixture file or run with `AUTO_MOCKER_FORCE=1` to re-generate.
 
+Failure behavior (always strict)
+- If a schema is missing or faker fails, the handler responds 500 and does not write a placeholder.
+- Invalid fixtures (including empty `{}` when the schema defines properties) respond 500.
+
 Types (optional)
 - If you expose OpenAPI response types under `@api/types.gen`, set `USE_TYPES_FOR_FIXTURES = true` in `src/mocks/mocker.ts` to add a `satisfies` clause in generated fixtures.
-

src/mocks/fixtures/README.md

@@ -10,4 +10,4 @@ Notes
 - If your project exposes OpenAPI response types via `@api/types.gen`, you can
   enable type enforcement by setting `USE_TYPES_FOR_FIXTURES = true` in
   `src/mocks/mocker.ts`.
-
+- Always strict: missing/failed generation returns 500 (no placeholder), and invalid fixtures return 500.

src/mocks/mocker.ts

@@ -171,7 +171,7 @@ export function autoGenerateHandlers() {
 
           const hasFile = fs.existsSync(fixtureFileName);
           if ((FORCE_REGENERATE || !hasFile) && successStatus !== "204") {
-            let payload: any = {};
+            let payload: any | undefined;
             if (successStatus) {
               const schema =
                 operation.responses?.[successStatus]?.content?.[
@@ -182,41 +182,42 @@ export function autoGenerateHandlers() {
                   const resolved = derefSchema(schema);
                   payload = jsf.generate(resolved);
                 } catch (e) {
-                  console.warn(
+                  console.error(
                     "[auto-mocker] jsf.generate failed for",
                     method.toUpperCase(),
                     rawPath,
                     e,
                   );
                 }
               } else {
-                console.warn(
+                console.error(
                   "[auto-mocker] no JSON schema for",
                   method.toUpperCase(),
                   rawPath,
                   "status",
                   successStatus,
                 );
-                payload = {};
               }
             }
 
-            const opType = successStatus
-              ? opResponseTypeName(method, rawPath)
-              : undefined;
-            const tsModule = buildMockModule(payload, {
-              opType,
-              useTypes: USE_TYPES_FOR_FIXTURES,
-            });
-            try {
-              fs.writeFileSync(fixtureFileName, tsModule);
-              console.log("[auto-mocker] wrote", fixtureFileName);
-            } catch (e) {
-              console.error(
-                "[auto-mocker] failed to write fixture",
-                fixtureFileName,
-                e,
-              );
+            if (payload !== undefined) {
+              const opType = successStatus
+                ? opResponseTypeName(method, rawPath)
+                : undefined;
+              const tsModule = buildMockModule(payload, {
+                opType,
+                useTypes: USE_TYPES_FOR_FIXTURES,
+              });
+              try {
+                fs.writeFileSync(fixtureFileName, tsModule);
+                console.log("[auto-mocker] wrote", fixtureFileName);
+              } catch (e) {
+                console.error(
+                  "[auto-mocker] failed to write fixture",
+                  fixtureFileName,
+                  e,
+                );
+              }
             }
           }
 
@@ -237,7 +238,7 @@ export function autoGenerateHandlers() {
             }
           } catch (e) {
             return new HttpResponse(
-              `Missing mock fixture: ${relPath}. ${e instanceof Error ? e.message : ""}`,
+              `[auto-mocker] Missing mock fixture: ${relPath}. ${e instanceof Error ? e.message : ""}`,
               { status: 500 },
             );
           }
@@ -248,13 +249,33 @@ export function autoGenerateHandlers() {
             ]?.schema;
           if (validateSchema) {
             const resolved = derefSchema(validateSchema);
-            const isValid = ajv.validate(resolved, data);
+            let isValid = ajv.validate(resolved, data);
+            // Treat empty object as invalid when schema exposes properties.
+            if (
+              isValid &&
+              data &&
+              typeof data === "object" &&
+              !Array.isArray(data) &&
+              Object.keys(data as any).length === 0 &&
+              (resolved as any)?.properties &&
+              Object.keys((resolved as any).properties).length > 0
+            ) {
+              isValid = false;
+            }
             if (!isValid) {
-              console.error("[auto-mocker] invalid mock response", {
-                fixtureFileName,
-                errors: ajv.errors,
+              const message = `fixture validation failed for ${method.toUpperCase()} ${rawPath} -> ${fixtureFileName}`;
+              console.error("[auto-mocker]", message, ajv.errors || []);
+              return new HttpResponse(`[auto-mocker] ${message}`, {
+                status: 500,
               });
             }
+          } else {
+            // No JSON schema to validate against: explicit failure
+            const message = `no JSON schema for ${method.toUpperCase()} ${rawPath} status ${successStatus ?? "200"}`;
+            console.error("[auto-mocker]", message);
+            return new HttpResponse(`[auto-mocker] ${message}`, {
+              status: 500,
+            });
           }
 
           return HttpResponse.json(data, {