fix more linter warnings

Signed-off-by: Juan Antonio Osorio <[email protected]>

Author: JAORMX

cmd/import-from-toolhive/main.go

@@ -63,7 +63,7 @@ func runImport(cmd *cobra.Command, args []string) error {
 		if verbose {
 			log.Printf("Loading registry from file: %s", sourceFile)
 		}
-		registryData, err = os.ReadFile(sourceFile)
+		registryData, err = os.ReadFile(sourceFile) // #nosec G304 - file path comes from command line flag
 		if err != nil {
 			return fmt.Errorf("failed to read file: %w", err)
 		}
@@ -72,7 +72,7 @@ func runImport(cmd *cobra.Command, args []string) error {
 		if verbose {
 			log.Printf("Fetching registry from URL: %s", sourceURL)
 		}
-		resp, err := http.Get(sourceURL)
+		resp, err := http.Get(sourceURL) // #nosec G107 - URL comes from command line flag
 		if err != nil {
 			return fmt.Errorf("failed to fetch registry: %w", err)
 		}
@@ -153,7 +153,7 @@ func importEntry(name string, server *toolhiveRegistry.ImageMetadata, outputDir
 	}
 
 	// Create the directory
-	if err := os.MkdirAll(entryDir, 0755); err != nil {
+	if err := os.MkdirAll(entryDir, 0750); err != nil {
 		return fmt.Errorf("failed to create directory: %w", err)
 	}
 
@@ -180,15 +180,15 @@ func importEntry(name string, server *toolhiveRegistry.ImageMetadata, outputDir
 	finalContent := header + string(yamlData)
 
 	// Write the spec.yaml file
-	if err := os.WriteFile(specPath, []byte(finalContent), 0644); err != nil {
+	if err := os.WriteFile(specPath, []byte(finalContent), 0600); err != nil {
 		return fmt.Errorf("failed to write spec.yaml: %w", err)
 	}
 
 	// Optionally create a README for complex entries
 	if shouldCreateReadme(server) {
 		readmePath := filepath.Join(entryDir, "README.md")
 		readmeContent := generateReadme(name, server)
-		if err := os.WriteFile(readmePath, []byte(readmeContent), 0644); err != nil {
+		if err := os.WriteFile(readmePath, []byte(readmeContent), 0600); err != nil {
 			// Non-fatal error
 			if verbose {
 				log.Printf("Warning: Failed to write README for %s: %v", name, err)

cmd/registry-builder/main.go

@@ -188,7 +188,7 @@ func buildToolhiveFormat(loader *registry.Loader, outputDir string) error {
 	}
 
 	// Ensure output directory exists
-	if err := os.MkdirAll(outputDir, 0755); err != nil {
+	if err := os.MkdirAll(outputDir, 0750); err != nil {
 		return fmt.Errorf("failed to create output directory: %w", err)
 	}
 

cmd/regup/main.go

@@ -113,7 +113,7 @@ func loadSpec(path string) (serverWithName, error) {
 	}
 
 	// Read the spec file
-	data, err := os.ReadFile(path)
+	data, err := os.ReadFile(path) // #nosec G304 - file path is constructed from known directory
 	if err != nil {
 		return serverWithName{}, fmt.Errorf("failed to read spec file: %w", err)
 	}
@@ -236,7 +236,7 @@ func updateServerInfo(server serverWithName) error {
 // updateYAMLPreservingStructure updates the YAML file while preserving comments and structure
 func updateYAMLPreservingStructure(path string, stars, pulls int) error {
 	// Read the original file
-	data, err := os.ReadFile(path)
+	data, err := os.ReadFile(path) // #nosec G304 - file path is constructed from known directory
 	if err != nil {
 		return fmt.Errorf("failed to read file: %w", err)
 	}
@@ -261,7 +261,7 @@ func updateYAMLPreservingStructure(path string, stars, pulls int) error {
 	}
 
 	// Write back to file
-	return os.WriteFile(path, buf.Bytes(), 0644)
+	return os.WriteFile(path, buf.Bytes(), 0600)
 }
 
 // updateMetadataInNode updates metadata fields in the YAML node tree

pkg/registry/loader.go

@@ -86,7 +86,7 @@ func (l *Loader) LoadAll() error {
 
 // LoadEntry loads a single registry entry from a YAML file
 func (l *Loader) LoadEntry(path string) (*types.RegistryEntry, error) {
-	file, err := os.Open(path)
+	file, err := os.Open(path) // #nosec G304 - path is constructed from known directory structure
 	if err != nil {
 		return nil, fmt.Errorf("failed to open file: %w", err)
 	}
@@ -410,7 +410,7 @@ func (b *Builder) WriteJSON(path string) error {
 
 	// Create the directory if it doesn't exist
 	dir := filepath.Dir(path)
-	if err := os.MkdirAll(dir, 0755); err != nil {
+	if err := os.MkdirAll(dir, 0750); err != nil {
 		return fmt.Errorf("failed to create directory: %w", err)
 	}
 
@@ -433,7 +433,7 @@ func (b *Builder) WriteJSON(path string) error {
 	}
 
 	// Write to file
-	if err := os.WriteFile(path, data, 0644); err != nil {
+	if err := os.WriteFile(path, data, 0600); err != nil {
 		return fmt.Errorf("failed to write file: %w", err)
 	}